Fix CVE-2023-45288#1680
Conversation
|
/ok-to-test |
|
/assign @sunnylovestiramisu |
| k8s.io/kube-openapi/pkg/validation/spec | ||
| # k8s.io/mount-utils v0.31.0-alpha.0 | ||
| ## explicit; go 1.22 | ||
| ## explicit; go 1.22.0 |
There was a problem hiding this comment.
Can do you do go mod tidy and go mod vendor to clean this up?
There was a problem hiding this comment.
run go mod tidy will change go.mod back to 1.22.0
| @@ -885,7 +885,7 @@ k8s.io/kube-openapi/pkg/spec3 | |||
| k8s.io/kube-openapi/pkg/util/proto | |||
| k8s.io/kube-openapi/pkg/validation/spec | |||
| # k8s.io/mount-utils v0.31.0-alpha.0 | |||
There was a problem hiding this comment.
Hmm not related to this PR but this is not right, why are we depending on the alpha version.
There was a problem hiding this comment.
It comes from dependabot cde24e7 Seems like we should revert it?
|
/retest |
|
/cherry-pick release-1.8 |
|
@dannawang0221: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.9 |
|
@dannawang0221: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.10 |
|
@dannawang0221: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.11 |
|
@dannawang0221: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.12 |
|
@dannawang0221: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.13 |
|
@dannawang0221: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dannawang0221, sunnylovestiramisu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dannawang0221: #1680 failed to apply on top of branch "release-1.8": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dannawang0221: #1680 failed to apply on top of branch "release-1.9": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dannawang0221: #1680 failed to apply on top of branch "release-1.10": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dannawang0221: #1680 failed to apply on top of branch "release-1.11": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dannawang0221: #1680 failed to apply on top of branch "release-1.12": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dannawang0221: #1680 failed to apply on top of branch "release-1.13": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: