Skip to content

Add support for read_ahead_kb mount flag#1627

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
pwschuurman:add-readahead-support
Mar 5, 2024
Merged

Add support for read_ahead_kb mount flag#1627
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
pwschuurman:add-readahead-support

Conversation

@pwschuurman
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds support for read_ahead_kb mount flag. This flag isn't passed directly to the mount command as an option, but it is used to set the readahead value for the underlying block device.

Does this PR introduce a user-facing change?:

Support for read_ahead_kb mount flag to change block device readahead

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from saikat-royc March 3, 2024 17:51
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from tyuchn March 3, 2024 17:51
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2024
@pwschuurman pwschuurman force-pushed the add-readahead-support branch 2 times, most recently from 16eaf30 to ff63c7a Compare March 4, 2024 18:01
Comment thread pkg/gce-pd-csi-driver/node.go
@pwschuurman pwschuurman force-pushed the add-readahead-support branch from ff63c7a to de3b3d1 Compare March 4, 2024 21:05
@pwschuurman
Copy link
Copy Markdown
Contributor Author

/retest

@msau42
Copy link
Copy Markdown
Contributor

msau42 commented Mar 5, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit d6b1856 into kubernetes-sigs:master Mar 5, 2024
@pwschuurman
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-1.13

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@pwschuurman: new pull request created: #1631

Details

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants