Skip to content

update klog version to latest. change %w unwrap to %v#1579

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
leiyiz:pollError
Jan 24, 2024
Merged

update klog version to latest. change %w unwrap to %v#1579
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
leiyiz:pollError

Conversation

@leiyiz
Copy link
Copy Markdown
Contributor

@leiyiz leiyiz commented Jan 22, 2024 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
in order to bump klog version, %w is no longer supported. %v should be used instead

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Error wrapping for `klog` logging is changed from `%w` to `%v` due to klog version bump.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leiyiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 22, 2024
@leiyiz
Copy link
Copy Markdown
Contributor Author

leiyiz commented Jan 22, 2024

#1575 updates klog but %w is no longer supported.

@sunnylovestiramisu
Copy link
Copy Markdown
Contributor

sunnylovestiramisu commented Jan 22, 2024

Does this worth make a note in release notes?

@leiyiz
Copy link
Copy Markdown
Contributor Author

leiyiz commented Jan 23, 2024

Does this worth make a note in release notes?

Yeah I think that makes sense

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 23, 2024
@sunnylovestiramisu
Copy link
Copy Markdown
Contributor

sunnylovestiramisu commented Jan 23, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 091a259 into kubernetes-sigs:master Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

@songjiaxun songjiaxun Awaiting requested review from songjiaxun

Assignees

@sunnylovestiramisu sunnylovestiramisu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leiyiz @k8s-ci-robot @sunnylovestiramisu