Skip to content

Update nvme /dev/ device search path to only identify drive/namespace paths#1485

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
pwschuurman:fix-nvme-device-paths
Nov 7, 2023
Merged

Update nvme /dev/ device search path to only identify drive/namespace paths#1485
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
pwschuurman:fix-nvme-device-paths

Conversation

@pwschuurman

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
The current code that finds NVMe device paths looks for /dev/nvme*, which returns partition and device paths. The mount code is only concerned about drive/namespace paths, so the found paths should be restricted to these.

Which issue(s) this PR fixes:
Fixes #1480

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Reduce log spam when identifying NVMe devices located in `/dev`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 7, 2023
@k8s-ci-robot k8s-ci-robot requested a review from leiyiz November 7, 2023 01:42
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from tyuchn November 7, 2023 01:42
@pwschuurman

Copy link
Copy Markdown
Contributor Author

/assign @amacaskill

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 7, 2023
@amacaskill

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 80887d6 into kubernetes-sigs:master Nov 7, 2023
@pwschuurman

Copy link
Copy Markdown
Contributor Author

/cherrypick release-1.12

@pwschuurman

Copy link
Copy Markdown
Contributor Author

/cherrypick release-1.11

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown

@pwschuurman: #1485 failed to apply on top of branch "release-1.12":

Applying: Update nvme /dev/ device search path to only identify drive/namespace paths
Using index info to reconstruct a base tree...
M	go.mod
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update nvme /dev/ device search path to only identify drive/namespace paths
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown

@pwschuurman: #1485 failed to apply on top of branch "release-1.11":

Applying: Update nvme /dev/ device search path to only identify drive/namespace paths
Using index info to reconstruct a base tree...
M	go.mod
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update nvme /dev/ device search path to only identify drive/namespace paths
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tyuchn added a commit that referenced this pull request Nov 8, 2023
…485-upstream-release-1.11

[release-1.11] Automated cherry pick of #1485: Update nvme /dev/ device search path to only identify
k8s-ci-robot added a commit that referenced this pull request Nov 8, 2023
…485-upstream-release-1.12

[release-1.12] Automated cherry pick of #1485: Update nvme /dev/ device search path to only identify
k8s-ci-robot added a commit that referenced this pull request Dec 15, 2023
…485-upstream-release-1.10

[release-1.10] Automated cherry pick of #1485: Update nvme /dev/ device search path to only identify
k8s-ci-robot added a commit that referenced this pull request Jan 23, 2024
…485-upstream-release-1.8

[release-1.8] Automated cherry pick of #1485: Update nvme /dev/ device search path to only identify
mattcary added a commit that referenced this pull request Jan 23, 2024
…485-upstream-release-1.9

[release-1.9] Automated cherry pick of #1485: Update nvme /dev/ device search path to only identify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix search pattern for PD-NVMe devices in findAvailableDevFsPaths

4 participants