conformance: follow-up on TLSRoute TLSRoute rejection conformance tests#4473
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/L
rostislavbobo
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/cc @rikatz |
| - name: http | ||
| port: 80 | ||
| protocol: HTTP | ||
| listeners: |
There was a problem hiding this comment.
extra listeners key here (thanks linter!! I would have not seen this!)
| from: Same | ||
| kinds: | ||
| - kind: HTTPRoute | ||
| - kind: TCPRoute |
There was a problem hiding this comment.
same from linter, while this is valid, apparently we enforce putting array items on 2 spaces below the parent field
There was a problem hiding this comment.
interesting, but OK
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, rostislavbobo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
tested, lgtm. Thanks! |
k8s-ci-robot
added
the
lgtm
…ts (kubernetes-sigs#4473) * TLSRoute: Use v1alpha3 * TLSRoute: Wait for namespace to be ready * TLSRoute: Test for no maching section name * TLSRoute: Test for not allowed protocol HTTP * TLSRoute: Test for not allowed kind * TLSRoute: Test for not allowed protocol HTTPS * TLSRoute: Fix lint
3 participants
What type of PR is this?
/kind test
/area conformance-test
What this PR does / why we need it:
This PR is a follow-up to address comments raised in #4433
Which issue(s) this PR fixes:
Fixes #
Part of #1579
Does this PR introduce a user-facing change?: