[release-1.4] Update CRD generator to handle errors encountered during generation#4357
Conversation
…ubernetes-sigs#4158) In addition to the generator fix, adjustments have been made to existing CRDs to correct errors which were not handled before, and `./hack/update-codegen.sh` was executed. The listType marker was added to two non-list fields in 78496d8 The MaxLength validation marker was used on an array field instead of MaxItems in 110bcaf
|
Welcome @weisdd! |
|
Hi @weisdd. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks @weisdd! Not sure if we'll find time to get another patch release out before v1.5, but approving in case we do. /ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, weisdd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
In #4158, there was a fix for kubebuilder annotations that, unfortunately, did not make it to the recent v1.4.1 due to a failed automated cherrypick attempt.
As suggested by @rikatz here, this PR contains a cherrypick of the commit from #4158, just in case there will be v1.4.2.
Does this PR introduce a user-facing change?: