Skip to content

[release-1.4] Update CRD generator to handle errors encountered during generation#4357

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-1.4from
weisdd:release-1.4
Jan 16, 2026
Merged

[release-1.4] Update CRD generator to handle errors encountered during generation#4357
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-1.4from
weisdd:release-1.4

Conversation

@weisdd
Copy link
Copy Markdown

@weisdd weisdd commented Dec 16, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

In #4158, there was a fix for kubebuilder annotations that, unfortunately, did not make it to the recent v1.4.1 due to a failed automated cherrypick attempt.

As suggested by @rikatz here, this PR contains a cherrypick of the commit from #4158, just in case there will be v1.4.2.

Does this PR introduce a user-facing change?:

The ExternalAuth HTTPRouteFilter now enforces a maximum of 64 items in the following fields:

- `grpc.allowedHeaders`
- `http.allowedHeaders`
- `http.allowedResponseHeaders`

…ubernetes-sigs#4158)

In addition to the generator fix, adjustments have been made to existing CRDs to
correct errors which were not handled before, and `./hack/update-codegen.sh`
was executed.

The listType marker was added to two non-list fields in 78496d8

The MaxLength validation marker was used on an array field instead of MaxItems in 110bcaf
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Dec 16, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @weisdd!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @weisdd. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 16, 2025
@robscott
Copy link
Copy Markdown
Member

Thanks @weisdd! Not sure if we'll find time to get another patch release out before v1.5, but approving in case we do.

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, weisdd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2026
@k8s-ci-robot k8s-ci-robot merged commit 0d0ca87 into kubernetes-sigs:release-1.4 Jan 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants