Skip to content

fix: target object status description #4275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: target object status description #4275

wants to merge 1 commit into from

Conversation

@guicassolato
Copy link
Contributor

@guicassolato guicassolato commented Nov 25, 2025

What type of PR is this?

/kind gep

What this PR does / why we need it:

Fix policy status conditions Enforced/PartiallyEnforced → Programmed/PartiallyEnforced in the description of the target object status.

Which issue(s) this PR fixes:

Bug reported at #4269.

Does this PR introduce a user-facing change?:

NONE

@guicassolato
fix: target object status description
4641f41 
Signed-off-by: Guilherme Cassolato <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Nov 25, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2025
DamianSawicki
DamianSawicki approved these changes Nov 26, 2025
View reviewed changes
Copy link

@DamianSawicki DamianSawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 26, 2025

@DamianSawicki: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rikatz
rikatz approved these changes Nov 27, 2025
View reviewed changes
Copy link
Member

@rikatz rikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DamianSawicki, guicassolato, rikatz
Once this PR has been reviewed and has the lgtm label, please assign youngnick for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg Awaiting requested review from arkodg

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

2 more reviewers

@rikatz rikatz rikatz approved these changes

@DamianSawicki DamianSawicki DamianSawicki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rikatz rikatz

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guicassolato @k8s-ci-robot @rikatz @DamianSawicki