-
Notifications
You must be signed in to change notification settings - Fork 620
Update coreDNS pod image tag #4240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.3
Are you sure you want to change the base?
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rhamini3 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @rhamini3! |
|
Hi @rhamini3. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| - -conf | ||
| - /root/Corefile | ||
| image: coredns/coredns | ||
| image: k8s.gcr.io/coredns/coredns:v1.13.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep this as latest? Pinning here seems like something that will get lost and not updated in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that k8s.gcr.io/coredns/coredns:latest exists because when I tried that I got this error:
message: 'unable to pull image or OCI artifact: pull image err: initializing
source docker://k8s.gcr.io/coredns/coredns:latest: reading manifest latest
in k8s.gcr.io/coredns/coredns: manifest unknown: Failed to fetch "latest";
artifact err: get manifest: build image source: reading manifest latest
in k8s.gcr.io/coredns/coredns: manifest unknown: Failed to fetch "latest"'
|
/ok-to-test /assign @kubernetes-sigs/gateway-api-conformance-reviewers @kubernetes-sigs/gateway-api-conformance-approvers |
|
The problem here is that updating this in the v1.3 branch will require us to release v1.3.1 to have that change take effect, as v1.3.0 is a tagged version. Generally, we don't do patch releases for anything other than the latest release. I understand and can see this is an issue, but I am not confident this is a big enough concern to trigger a patch release. |
|
@rhamini3 I think @youngnick has the right of it here, especially since this is a change to conformance. Could you retarget this to If your setup needs this in order to submit a conformance run, I would say:
I'll happily take a conformance report with this patch included. 🙂 Thanks for looking into this!! 🙂 |
|
@kflynn so the main branch already pins to a specific coreDNS image, same with release-1.4. I think it was missed in release-1.3. Currently our conformance is running by picking up the patch commit |
What type of PR is this?
/kind bug
Optionally add one or more of the following kinds if applicable:
/area conformance-test
What this PR does / why we need it:
Which issue(s) this PR fixes:
*Automatically closes linked issue when PR is merged.
Fixes #4239
Does this PR introduce a user-facing change?:
NONE
Updating the image tag to:
k8s.gcr.io/coredns/coredns:v1.13.1allows the pod to go into ready state and conformance tests can continue on