Skip to content

Conversation

@rhamini3
Copy link

@rhamini3 rhamini3 commented Nov 12, 2025

What type of PR is this?
/kind bug

Optionally add one or more of the following kinds if applicable:
/area conformance-test

What this PR does / why we need it:

Which issue(s) this PR fixes:
*Automatically closes linked issue when PR is merged.
Fixes #4239

Does this PR introduce a user-facing change?:
NONE

coreDNS pod is never ready due to message:
        message: 'Back-off pulling image "coredns/coredns": ErrImagePull: short name
          mode is enforcing, but image name coredns/coredns:latest returns ambiguous
          list'
        reason: ImagePullBackOff

Updating the image tag to: k8s.gcr.io/coredns/coredns:v1.13.1 allows the pod to go into ready state and conformance tests can continue on

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/conformance-test Issues or PRs related to Conformance tests. labels Nov 12, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 12, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rhamini3 / name: Ishmam Amin (4c69e48)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhamini3
Once this PR has been reviewed and has the lgtm label, please assign arkodg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @rhamini3!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @rhamini3. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 12, 2025
- -conf
- /root/Corefile
image: coredns/coredns
image: k8s.gcr.io/coredns/coredns:v1.13.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this as latest? Pinning here seems like something that will get lost and not updated in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that k8s.gcr.io/coredns/coredns:latest exists because when I tried that I got this error:

message: 'unable to pull image or OCI artifact: pull image err: initializing
          source docker://k8s.gcr.io/coredns/coredns:latest: reading manifest latest
          in k8s.gcr.io/coredns/coredns: manifest unknown: Failed to fetch "latest";
          artifact err: get manifest: build image source: reading manifest latest
          in k8s.gcr.io/coredns/coredns: manifest unknown: Failed to fetch "latest"'

@mikemorris
Copy link
Contributor

/ok-to-test

/assign @kubernetes-sigs/gateway-api-conformance-reviewers @kubernetes-sigs/gateway-api-conformance-approvers

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2025
@youngnick
Copy link
Contributor

The problem here is that updating this in the v1.3 branch will require us to release v1.3.1 to have that change take effect, as v1.3.0 is a tagged version.

Generally, we don't do patch releases for anything other than the latest release. I understand and can see this is an issue, but I am not confident this is a big enough concern to trigger a patch release.

@robscott @shaneutt @kflynn any thoughts?

@kflynn
Copy link
Contributor

kflynn commented Nov 17, 2025

@rhamini3 I think @youngnick has the right of it here, especially since this is a change to conformance. Could you retarget this to main so we can take it into our next release?

If your setup needs this in order to submit a conformance run, I would say:

  • Make the change locally
  • Run conformance and generate a report
  • When you PR your conformance test, include this patch in your README as part of your notes on how to reproduce your results.

I'll happily take a conformance report with this patch included. 🙂 Thanks for looking into this!! 🙂

@rhamini3
Copy link
Author

@kflynn so the main branch already pins to a specific coreDNS image, same with release-1.4. I think it was missed in release-1.3. Currently our conformance is running by picking up the patch commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants