Fix incorrect Kubebuilder validation markers

apisx/v1alpha1/shared_types.go

@@ -27,7 +27,6 @@ type (
 	Hostname                   = v1.Hostname
 	Kind                       = v1.Kind
 	ObjectName                 = v1.ObjectName
-	PortNumber                 = v1.PortNumber
 	ProtocolType               = v1.ProtocolType
 	RouteGroupKind             = v1.RouteGroupKind
 	SectionName                = v1.SectionName
@@ -38,6 +37,20 @@ type (
 	SessionPersistence         = v1.SessionPersistence
 )
 
+// PortNumber defines a network port.
+//
+// +kubebuilder:validation:Minimum=0
+// +kubebuilder:validation:Maximum=65535
+type PortNumber int32
+
+// StatusPortNumber defines a network port in status fields.
+// Unlike PortNumber, this does not allow 0 since status fields
+// reflect actual assigned ports.
+//
+// +kubebuilder:validation:Minimum=1
+// +kubebuilder:validation:Maximum=65535
+type StatusPortNumber int32
+
 // ParentGatewayReference identifies an API object including its namespace,
 // defaulting to Gateway.
 type ParentGatewayReference struct {

apisx/v1alpha1/xlistenerset_types.go

@@ -167,8 +167,6 @@ type ListenerEntry struct {
 	// +optional
 	//
 	// +kubebuilder:default=0
-	// +kubebuilder:validation:Minimum=0
-	// +kubebuilder:validation:Maximum=65535
 	Port PortNumber `json:"port,omitempty"`
 
 	// Protocol specifies the network protocol this listener expects to receive.
@@ -253,11 +251,8 @@ type ListenerEntryStatus struct {
 
 	// Port is the network port the listener is configured to listen on.
 	//
-	// +kubebuilder:validation:Minimum=1
-	// +kubebuilder:validation:Maximum=65535
-	//
 	// +required
-	Port PortNumber `json:"port"`
+	Port StatusPortNumber `json:"port"`
 
 	// SupportedKinds is the list indicating the Kinds supported by this
 	// listener. This MUST represent the kinds an implementation supports for

hack/update-clientset.sh

@@ -118,3 +118,10 @@ go run sigs.k8s.io/controller-tools/cmd/controller-gen \
   object:headerFile=${SCRIPT_ROOT}/hack/boilerplate/boilerplate.generatego.txt \
   paths="./apis/..." \
   paths="./apisx/..."
+
+echo "Validating CRD markers"
+go run sigs.k8s.io/controller-tools/cmd/controller-gen \
+  crd:headerFile=${SCRIPT_ROOT}/hack/boilerplate/boilerplate.generatego.txt \
+  paths="./apis/..." \
+  paths="./apisx/..." \
+  output:crd:dir=/tmp/gateway-api-crd-validation