-
Couldn't load subscription status.
- Fork 605
Fix PortNumber type to support controller-gen #4049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Erik Godding Boye <[email protected]>
|
From @JoelSpeed's comments on another PR, it seems like this fix may continue working even after the controller-tools PR is fixed? If so, this seems worth doing to me. |
|
Thanks Nick! My priority is to be able to bump cert-manager to K8s 1.34, and it seems we need this PR merged or a release of controller-tools containing a fix for the issue. Last resort is copy-modify of the gateway-api types reused in cert-manager API, which is something I'm trying to avoid. At least at this point. |
|
/lgtm Should work in the long term, provided clients are on Go 1.23 or higher. The go module here requires 1.24 so I think this is safe |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR suggests a workaround for kubernetes-sigs/controller-tools#1269. There is an open PR to fix this issue, kubernetes-sigs/controller-tools#1270, but it appears like the required change is a bit controversial and will at least take some time to get available in a new release of controller-tools.
With the minor change in this PR, I am able to generate CRDs in my WIP PR to upgrade cert-manager to K8s 1.34. See cert-manager/cert-manager@a122dd6.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
CC: @dprotaso @JoelSpeed