Skip to content

Conversation

@erikgb
Copy link
Member

@erikgb erikgb commented Aug 31, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR suggests a workaround for kubernetes-sigs/controller-tools#1269. There is an open PR to fix this issue, kubernetes-sigs/controller-tools#1270, but it appears like the required change is a bit controversial and will at least take some time to get available in a new release of controller-tools.

With the minor change in this PR, I am able to generate CRDs in my WIP PR to upgrade cert-manager to K8s 1.34. See cert-manager/cert-manager@a122dd6.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

CC: @dprotaso @JoelSpeed

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 31, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 31, 2025
@erikgb erikgb changed the title WIP: Fix PortNumber type to support controller-gen Fix PortNumber type to support controller-gen Aug 31, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2025
@youngnick
Copy link
Contributor

From @JoelSpeed's comments on another PR, it seems like this fix may continue working even after the controller-tools PR is fixed? If so, this seems worth doing to me.

@erikgb
Copy link
Member Author

erikgb commented Sep 1, 2025

Thanks Nick! My priority is to be able to bump cert-manager to K8s 1.34, and it seems we need this PR merged or a release of controller-tools containing a fix for the issue. Last resort is copy-modify of the gateway-api types reused in cert-manager API, which is something I'm trying to avoid. At least at this point.

@JoelSpeed
Copy link

/lgtm

Should work in the long term, provided clients are on Go 1.23 or higher. The go module here requires 1.24 so I think this is safe

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2025
@youngnick
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 477155d into kubernetes-sigs:main Sep 1, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants