TLSRoute: Require hostnames via +required#3918
TLSRoute: Require hostnames via +required#3918k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Conversation
|
Hi @rostislavbobo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/lgtm @rostislavbobo please just fix the PR description to contain the proper entry as of: Thank you! |
|
/lgtm cancel Canceling lgtm due to the required changes |
There was a problem hiding this comment.
Thanks @rostislavbobo, @rikatz and @JoelSpeed!
/approve
|
Thanks you @JoelSpeed , @rikatz , @shaneutt for the review! Using |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rostislavbobo, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm leaving the unhold for project maintainers :) Thanks @rostislavbobo !! |
* TLSRoute: Require hostnames, no omitempty * TLSRoute: Require hostnames using +required
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR makes the
hostnamesfield required, as an addition to #3872.Which issue(s) this PR fixes:
Fixes #3871
Does this PR introduce a user-facing change?: