Update golangci v2

[tylerauerbeck]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This PR updates golangci-lint to v2 to keep the linters and linting tool up to date.

NOTE: I broke the fix for a specific lint static check QF1008 into a second commit as different projects tend to have different opinions on this. If it's desired to leave those in place and instead ignore this lint, we can go back and drop that commit instead and either configure this in the config file or use //nolint where appropriate.

Which issue(s) this PR fixes:

Fixes #3801

Does this PR introduce a user-facing change?:
NONE

[k8s-ci-robot]

Welcome @tylerauerbeck!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @tylerauerbeck. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[LiorLieberman]

/cc @robscott opinions?

[LiorLieberman]

And thanks @tylerauerbeck, this is great!

[robscott]

Thanks @tylerauerbeck! These changes look like a nice improvement to me. Will defer to someone else for final signoff.

/cc @mlavacca @shaneutt @youngnick

/ok-to-test
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, tylerauerbeck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaneutt]

CI is grumpy:

 Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2 

[rikatz]

@tylerauerbeck you need to bump the version here: https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/verify-golint.sh#L21

[rikatz]

/release-note-none

[rikatz]

@tylerauerbeck 👋
Are you willing to come back to this effort?

Thanks!!

[rikatz]

@tylerauerbeck friendly ping :)

[tylerauerbeck]

Hey sorry, just catching up. I'll get this cleaned up here shortly.

[rikatz]

thanks! let me know and I will take a look on it!

[tylerauerbeck]

@rikatz I fumbled fixing up some merge conflicts, so went back through and updated this with all of the latest. Feel free to take a look and let me know if anything stands out.

[k8s-ci-robot]

@tylerauerbeck: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gateway-api-verify	c403c62	link	true	/test pull-gateway-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rikatz]

thanks @tylerauerbeck !

I can see that there are still some failures on tools, do you mind fixing?

Also, apparently there are some "complains" about build tags on the API, but I can't remember this previously happening, is this being ignored? Can you double check if this is something new? If so, maybe we need to ignore it

[rikatz]

/close

This was fixed via #4377

[k8s-ci-robot]

@rikatz: Closed this PR.

Details

In response to this:

/close

This was fixed via #4377

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.