Skip to content

conformance-tests: fix flake in ExpectMirroredRequest #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

conformance-tests: fix flake in ExpectMirroredRequest #3708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion conformance/utils/http/mirror.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ func ExpectMirroredRequest(t *testing.T, client client.Client, clientset clients
var wg sync.WaitGroup
wg.Add(len(mirrorPods))

assertionStart := time.Now()

for _, mirrorPod := range mirrorPods {
go func(mirrorPod MirroredBackend) {
defer wg.Done()
Expand All @@ -50,7 +52,7 @@ func ExpectMirroredRequest(t *testing.T, client client.Client, clientset clients

tlog.Log(t, "Searching for the mirrored request log")
tlog.Logf(t, `Reading "%s/%s" logs`, mirrorPod.Namespace, mirrorPod.Name)
logs, err := kubernetes.DumpEchoLogs(mirrorPod.Namespace, mirrorPod.Name, client, clientset, time.Now())
logs, err := kubernetes.DumpEchoLogs(mirrorPod.Namespace, mirrorPod.Name, client, clientset, assertionStart)
if err != nil {
tlog.Logf(t, `Couldn't read "%s/%s" logs: %v`, mirrorPod.Namespace, mirrorPod.Name, err)
return false
Expand Down