Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: mark reporting structure grad criteria as complete for GEP 1709 #2827

Merged
merged 1 commit into from
Feb 28, 2024
Merged

docs: mark reporting structure grad criteria as complete for GEP 1709 #2827

merged 1 commit into from
Feb 28, 2024

Conversation

shaneutt
Copy link
Member

As per the sub-tasks in #1709 all the reporting structure work has been completed (thank you @mlavacca!). This updates the GEP to reflect that, and now all that's left is documentation as per #2322 (though Mattia also added a bit of documentation as a part of the reporting work recently as well).

@shaneutt shaneutt added the kind/gep PRs related to Gateway Enhancement Proposal(GEP) label Feb 28, 2024
@shaneutt shaneutt added this to the v1.1 milestone Feb 28, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 28, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2024
mlavacca
mlavacca approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott
Copy link
Member

Thanks @shaneutt and @mlavacca!

/lgtm
/hold cancel
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 28, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2024
@shaneutt shaneutt merged commit 4f71b23 into main Feb 28, 2024
8 checks passed
@shaneutt shaneutt deleted the shaneutt-patch-1 branch February 28, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca mlavacca approved these changes

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

@gcs278 gcs278 Awaiting requested review from gcs278

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shaneutt @k8s-ci-robot @robscott @mlavacca