-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mode introduced to conformance report API #2801
feat: mode introduced to conformance report API #2801
Conversation
Signed-off-by: Mattia Lavacca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it the "mode" was meant to allow us to run entirely different sets of tests and provide different reports for different "modes" under the same organization
and project
, and therefore under the same ConformanceReport
. Don't we need to significantly change the reporting structure here to support multiple modes in a single report?
That was the initial idea I proposed in the related GEP update. After a few rounds of reviews, we eventually decided to keep the report simpler (with a single mode) and introduced a structured way to keep multiple reports, each specifying a specific mode. An example is in this draft PR, where the table of contents contains multiple rows, each specific to a combination of This way, an implementation can have multiple versions supporting the same Gateway API version, with different combinations of Gateway API channels and operating modes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right OK, that rings a bell now.
/approve
/cc @youngnick @robscott
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @mlavacca! /lgtm |
What type of PR is this?
/kind feature
/area conformance
What this PR does / why we need it:
The mode field has been added to the conformance report API. This field makes customization of the implementations' operating mode possible.
Which issue(s) this PR fixes:
Fixes #2739
Does this PR introduce a user-facing change?: