generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 616
GEP: Client Certificate Validation for TLS terminating at the Gateway Listener #2080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:main
from
arkodg:gep-client-cert-validation-gateway
Jul 20, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # GEP-91: Client Certificate Validation for TLS terminating at the Gateway Listener | ||
|
|
||
| * Issue: [#91](https://github.com/kubernetes-sigs/gateway-api/issues/91) | ||
| * Status: Provisional | ||
|
|
||
| (See definitions in [GEP Status][/contributing/gep#status].) | ||
|
|
||
| ## TLDR | ||
|
|
||
| This GEP proposes a way to validate the TLS certificate presented by the downstream client to the server | ||
| (Gateway Listener in this case) during a [TLS Handshake Protocol][], also commonly referred to as mutual TLS (mTLS). | ||
|
|
||
| ## Goals | ||
| - Define an API field to specify the CA Certificate within the Gateway Listener configuration that can be used as a trusted anchor to validate the certificates presented by the client. | ||
|
|
||
| ## Non-Goals | ||
| - Define other fields that can be used to verify the client certificate such as the Cerificate Hash or Subject Alt Name. | ||
|
|
||
| ## References | ||
|
|
||
| [TLS Handshake Protocol]: https://www.rfc-editor.org/rfc/rfc5246#section-7.4 | ||
| [Certificate Path Validation]: https://www.rfc-editor.org/rfc/rfc5280#section-6 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the existing
certificateRefsfield where the CA certificate would be specified? Is the idea that this GEP will add a field that can be used to specify something like a client validation cacert key in acacertificateRefssecret, for example? Maybe adding an API section with a proposal would be helpful to start the discussion?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah you're right @frankbu , ive been advised to not define the HOW until the the maintainers have agreed on the goals here, so taking it one step at a time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, this goal of adding a way to config mTLS termination in a Gateway is valuable and very contained scope IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that feels like the inevitable placement here. Let's get this in and then we can work on the implementation details.