Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: wait for namespace to be ready in TLSRoute test #2067

Merged
merged 1 commit into from
May 26, 2023

Conversation

skriss
Copy link
Contributor

@skriss skriss commented May 26, 2023

What type of PR is this?
/kind test
/area conformance

What this PR does / why we need it:
Since the TLSRoute test creates a new Gateway, wait for
the namespace/contained pods to be ready before
proceeding.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

Since this test creates a new Gateway, wait for
the namespace/contained pods to be ready before
proceeding.

Signed-off-by: Steve Kriss <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/test area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 26, 2023
@sunjayBhatia
Copy link
Member

seems like a good candidate for 0.7 backport

@robscott
Copy link
Member

Thanks @skriss!

/lgtm
/approve
/cherry-pick release-0.7

@k8s-infra-cherrypick-robot

@robscott: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you.

In response to this:

Thanks @skriss!

/lgtm
/approve
/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, skriss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@robscott robscott added this to the v0.7.1 milestone May 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit ac013db into kubernetes-sigs:main May 26, 2023
@k8s-infra-cherrypick-robot

@robscott: new pull request created: #2068

In response to this:

Thanks @skriss!

/lgtm
/approve
/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants