Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEP 1709: ConformanceReports prototype API #1791

Conversation

shaneutt
Copy link
Member

@shaneutt shaneutt commented Mar 8, 2023

What type of PR is this?

/kind feature
/kind gep
/kind test
/area conformance

What this PR does / why we need it:

This supports #1784 by adding an experimental version of the ConformanceReport as described in GEP 1709. Because the GEP is currently considered to be in the Prototyping status, the rules we've set for that status indicate content must not be distributed in a release, so this PR introduces the idea of using Golang build tags as the mechanism to ensure the prototype content is not directly distributed as part of any upcoming release.

@shaneutt shaneutt added this to the v1.0.0 milestone Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP) kind/test area/conformance labels Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2023
@shaneutt shaneutt marked this pull request as draft March 8, 2023 16:53
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2023
@shaneutt
Copy link
Member Author

shaneutt commented Mar 8, 2023

Currently considered a draft, as it's based on #1783 which needs to merge first.

@shaneutt shaneutt added blocked tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2023
@shaneutt shaneutt force-pushed the shaneutt/conformance-reports-prototype-api branch from 7d28959 to 6c8539d Compare March 8, 2023 18:16
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Mar 8, 2023
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2023
@shaneutt shaneutt force-pushed the shaneutt/conformance-reports-prototype-api branch from 6c8539d to 89f7ecd Compare March 9, 2023 12:44
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2023
@shaneutt shaneutt force-pushed the shaneutt/conformance-reports-prototype-api branch from 89f7ecd to 80f7e70 Compare March 13, 2023 13:50
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Mar 13, 2023
@shaneutt shaneutt force-pushed the shaneutt/conformance-reports-prototype-api branch from 80f7e70 to 1114177 Compare March 13, 2023 20:42
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Mar 13, 2023
@shaneutt shaneutt marked this pull request as ready for review March 13, 2023 21:50
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2023
@shaneutt shaneutt requested review from youngnick and removed request for bowei March 13, 2023 21:50
@shaneutt shaneutt force-pushed the shaneutt/conformance-reports-prototype-api branch 2 times, most recently from 8805776 to cae7cc5 Compare March 13, 2023 23:08
@shaneutt shaneutt removed the blocked label Mar 13, 2023
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shaneutt! A couple tiny nits but otherwise LGTM.

conformance/apis/v1alpha1/conformanceprofile.go Outdated Show resolved Hide resolved
conformance/apis/v1alpha1/conformanceprofile.go Outdated Show resolved Hide resolved
@shaneutt shaneutt force-pushed the shaneutt/conformance-reports-prototype-api branch from cae7cc5 to 5fafdfa Compare March 15, 2023 18:03
@shaneutt shaneutt requested a review from robscott March 15, 2023 18:04
@shaneutt shaneutt force-pushed the shaneutt/conformance-reports-prototype-api branch from 5fafdfa to 47f5fe7 Compare March 15, 2023 20:45
conformance/apis/v1alpha1/statistics.go Outdated Show resolved Hide resolved
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaneutt shaneutt force-pushed the shaneutt/conformance-reports-prototype-api branch from 47f5fe7 to f964ad2 Compare March 16, 2023 13:12
These have been added behind an "experimental" build tag
as per the requirements of the relevant GEP which is in
Prototyping status.
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, shaneutt, sunjayBhatia, Xunzhuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8bd680b into kubernetes-sigs:main Mar 16, 2023
@shaneutt shaneutt deleted the shaneutt/conformance-reports-prototype-api branch March 16, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP) kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants