-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEP 1709: ConformanceReports prototype API #1791
GEP 1709: ConformanceReports prototype API #1791
Conversation
Currently considered a draft, as it's based on #1783 which needs to merge first. |
7d28959
to
6c8539d
Compare
6c8539d
to
89f7ecd
Compare
89f7ecd
to
80f7e70
Compare
80f7e70
to
1114177
Compare
8805776
to
cae7cc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shaneutt! A couple tiny nits but otherwise LGTM.
cae7cc5
to
5fafdfa
Compare
5fafdfa
to
47f5fe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
47f5fe7
to
f964ad2
Compare
These have been added behind an "experimental" build tag as per the requirements of the relevant GEP which is in Prototyping status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, shaneutt, sunjayBhatia, Xunzhuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/kind gep
/kind test
/area conformance
What this PR does / why we need it:
This supports #1784 by adding an experimental version of the
ConformanceReport
as described in GEP 1709. Because the GEP is currently considered to be in thePrototyping
status, the rules we've set for that status indicate content must not be distributed in a release, so this PR introduces the idea of using Golang build tags as the mechanism to ensure the prototype content is not directly distributed as part of any upcoming release.