Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: GEP 1709 change status to new prototyping GEP status #1782

Conversation

shaneutt
Copy link
Member

@shaneutt shaneutt commented Mar 7, 2023

What type of PR is this?

/kind gep

What this PR does / why we need it:

This supports #1709 by moving the GEP into a new Prototyping status, indicating that we're going to be doing some active testing and experimentation to see how we like things and ultimately feed back into further iterations on the GEP.

NOTE: Originally I went for Experimental to make a clear indication to the community that we're going to be doing some
experimentation before we seek consensus and move to implementable, however we use Experimental for something
somewhat specific right now so there was some concern this would be confusing. The new Prototyping status is simply
an extension of Provisional intended to allow community members to signal the intent to incorporate prototyping as part of
the GEP development process.

This also adds several small TODO notes based on feedback at recent community meetings and general clarifications in the GEP.

@shaneutt shaneutt added kind/gep PRs related to Gateway Enhancement Proposal(GEP) area/conformance labels Mar 7, 2023
@shaneutt shaneutt added this to the v1.0.0 milestone Mar 7, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 7, 2023
@shaneutt shaneutt force-pushed the shaneutt/conformance-profiles-experimental branch from a8db971 to bf739d8 Compare March 7, 2023 18:35
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2023
@shaneutt shaneutt added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Mar 7, 2023
@shaneutt shaneutt changed the title docs: GEP 1709 change status to experimental docs: GEP 1709 change status to new prototyping GEP status Mar 7, 2023
@shaneutt shaneutt force-pushed the shaneutt/conformance-profiles-experimental branch from fc2f89a to 4d6d574 Compare March 7, 2023 20:58
@shaneutt shaneutt force-pushed the shaneutt/conformance-profiles-experimental branch 2 times, most recently from 4787877 to 9069297 Compare March 7, 2023 21:02
geps/gep-1709.md Outdated Show resolved Hide resolved
@shaneutt shaneutt force-pushed the shaneutt/conformance-profiles-experimental branch from 4b03bfa to daadc89 Compare March 7, 2023 21:09
@shaneutt shaneutt requested a review from arkodg March 7, 2023 21:09
@shaneutt shaneutt added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 7, 2023
Co-authored-by: Arko Dasgupta <[email protected]>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work on this @shaneutt!

geps/overview.md Outdated Show resolved Hide resolved
geps/gep-1709.md Show resolved Hide resolved
Comment on lines +69 to +73
* **Prototyping:** An extension of `Provisional` which can be opted in to in
order to indicate to the community that there are some active practical tests
and experiments going on which are intended to be a part of the development
of this GEP. This may include APIs or code, but that content _must_ not be
distributed with releases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new proposed status feels like it's representative of the current state of some GAMMA GEPs.

/cc @howardjohn @keithmattix @mikemorris

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - I like Prototyping better than Provisional

@shaneutt shaneutt requested a review from robscott March 7, 2023 21:22
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @shaneutt!

geps/gep-1709.md Show resolved Hide resolved
geps/gep-1709.md Show resolved Hide resolved
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shaneutt!

/approve

geps/overview.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, keithmattix, robscott, shaneutt, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaneutt shaneutt requested a review from robscott March 7, 2023 22:34
@robscott
Copy link
Member

robscott commented Mar 7, 2023

Thanks @shaneutt!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit f844222 into kubernetes-sigs:main Mar 7, 2023
@shaneutt shaneutt deleted the shaneutt/conformance-profiles-experimental branch March 7, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

7 participants