Skip to content

Commit

Permalink
Fix bugs in GatewayWithAttachedRoutes
Browse files Browse the repository at this point in the history
* Set status to `False` for `notAccepted` Route condition

* Remove `Accepted` condition from `status.listeners[0].conditions`
since it is not mandatory for the `Accepted` to be set. In this case
the `ResolvedRefs=False` due to `InvalidCertificateRef` so an
implementation may choose to not generate any listener config

Signed-off-by: Arko Dasgupta <[email protected]>
  • Loading branch information
arkodg committed Oct 27, 2023
1 parent ee42a6d commit 51e35c3
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions conformance/tests/gateway-with-attached-routes.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,6 @@ var GatewayWithAttachedRoutes = suite.ConformanceTest{
Kind: v1.Kind("HTTPRoute"),
}},
Conditions: []metav1.Condition{
{
Type: string(v1.ListenerConditionAccepted),
Status: metav1.ConditionTrue,
Reason: "", // any reason
},
{
Type: string(v1.ListenerConditionProgrammed),
Status: metav1.ConditionFalse,
Expand All @@ -125,7 +120,7 @@ var GatewayWithAttachedRoutes = suite.ConformanceTest{
hrouteNN := types.NamespacedName{Name: "http-route-4", Namespace: "gateway-conformance-infra"}
notAccepted := metav1.Condition{
Type: string(v1.RouteConditionAccepted),
Status: metav1.ConditionTrue,
Status: metav1.ConditionFalse,
Reason: "", // any reason
}
unresolved := metav1.Condition{
Expand Down

0 comments on commit 51e35c3

Please sign in to comment.