Skip to content

Conversation

@liu-cong
Copy link
Contributor

@liu-cong liu-cong commented Jun 4, 2025

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 4, 2025
@netlify
Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit b0c9b97
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6840b4b366c97000080c0a68
😎 Deploy Preview https://deploy-preview-923--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested review from danehans and robscott June 4, 2025 21:03
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 4, 2025
@@ -0,0 +1,89 @@
# Prefix Cache Aware Plugin Configuration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the link not pointing to main intentionally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a permanent link. Main can change.

@nirrozenbaum
Copy link
Contributor

do we expect every plugin to have this kind of configuration guide?

@liu-cong
Copy link
Contributor Author

liu-cong commented Jun 4, 2025

do we expect every plugin to have this kind of configuration guide?

I think in general yes. We should have a doc listing the configuration options and explain what they are. This PR focuses on prefix plugin only though. This is more user/operator facing and we don't expect them to read the code.

@ahg-g
Copy link
Contributor

ahg-g commented Jun 4, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit b62931e into kubernetes-sigs:main Jun 4, 2025
8 checks passed
@liu-cong liu-cong deleted the prefix-ug branch June 5, 2025 15:37
shmuelk pushed a commit to shmuelk/gateway-api-inference-extension that referenced this pull request Jun 9, 2025
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants