Skip to content

fix: [Flow Control]: Optionally disable endpoint subset filtering while dispatching requests#2126

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
aishukamal:sfz
Jan 12, 2026
Merged

fix: [Flow Control]: Optionally disable endpoint subset filtering while dispatching requests#2126
k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
aishukamal:sfz

Conversation

@aishukamal
Copy link
Copy Markdown
Contributor

@aishukamal aishukamal commented Jan 12, 2026 •
edited
Loading

Fixes a bug where queued requests during Scale-from-Zero fail to be dispatched due to stale x-gateway-destination-endpoint-subset metadata.

What type of PR is this?
/kind bug
/kind feature

What this PR does / why we need it:
This PR adds an option to disable subset filtering in EPP. If we don't disable subset filtering, all requests sent during SFZ will timeout and fail.

Which issue(s) this PR fixes:

Fixes #2117

Does this PR introduce a user-facing change?:

It introduces a user-facing option that can be configured to disable subset filtering.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 12, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 12, 2026 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit cd78865
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/696562ef441fab00081d7e31
😎 Deploy Preview https://deploy-preview-2126--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jan 12, 2026 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 12, 2026

Welcome @aishukamal!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 12, 2026

Hi @aishukamal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 12, 2026
LukeAVanDrie
LukeAVanDrie reviewed Jan 12, 2026
View reviewed changes
Comment thread pkg/epp/requestcontrol/locator.go
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Jan 12, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2026
@aishukamal
Copy link
Copy Markdown
Contributor Author

aishukamal commented Jan 12, 2026

/retest

@aishukamal
Copy link
Copy Markdown
Contributor Author

aishukamal commented Jan 12, 2026

/retest

@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Jan 12, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aishukamal, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2026
@k8s-ci-robot k8s-ci-robot merged commit aaa9062 into kubernetes-sigs:main Jan 12, 2026
9 checks passed
@aishukamal
Copy link
Copy Markdown
Contributor Author

aishukamal commented Jan 14, 2026

@kfswain I saw that you triggered a cherry-pick request for #2143. We also need to cherry-pick this change into v1.3 for SFZ to work.

@kfswain
Copy link
Copy Markdown
Collaborator

kfswain commented Jan 14, 2026

/cherrypick release-1.3

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jan 14, 2026

@kfswain: new pull request created: #2155

Details

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 14, 2026
Merged
elevran pushed a commit to llm-d/llm-d-router that referenced this pull request Apr 23, 2026
@aishukamal
fix: [Flow Control]: Optionally disable endpoint subset filtering whi…
c3e4412 
…le dispatching requests (kubernetes-sigs/gateway-api-inference-extension#2126)

* Optionally disable endpoint subset filtering while dispatching requests from epp

* Fix formatting issues

* Address comments, use variadic function args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elevran elevran Awaiting requested review from elevran

@liu-cong liu-cong Awaiting requested review from liu-cong

1 more reviewer

@LukeAVanDrie LukeAVanDrie LukeAVanDrie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kfswain kfswain

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Flow Control] Requests queued during scale-from-zero never dispatch due to stale subset metadata

6 participants

@aishukamal @k8s-ci-robot @ahg-g @kfswain @k8s-infra-cherrypick-robot @LukeAVanDrie