-
Notifications
You must be signed in to change notification settings - Fork 201
WIP: refactor: refactor monitoring session #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP: refactor: refactor monitoring session #1906
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: capri-xiyue The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
liu-cong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @JeffLuoo Did we decide to deprecate monitoring.gke.enabled and use provider:gke to enable GKE monitoring?
@capri-xiyue Note we set monitoring.gke in llm-d user guides today, but I assume deprecating it just means monitoring.gke becomes a noop right?
| kubernetes.io/service-account.name: {{ $metricsReadSA }} | ||
| type: kubernetes.io/service-account-token | ||
| --- | ||
| apiVersion: monitoring.googleapis.com/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note this is only used in GKE (and therefore it was in gke.yaml)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. for resources that are gke specific, it's preferred to have it in a separate gke.yaml file.
now we just need to change the conditional, so instead of checking gke.enabled, we might check for provider.name == gke
Yes, there is already a deprecation note. We need to update the guides in GKE, the previous release now supports both, so we can safely migrate the guide. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
gke needs to be removed in monitoring session
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: