Skip to content

Conversation

@capri-xiyue
Copy link
Contributor

@capri-xiyue capri-xiyue commented Nov 26, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
gke needs to be removed in monitoring session

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

there is no `inferenceExtension.monitoring.gke` in `inferencePool` helm chart

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 26, 2025
@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 67a1f40
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69273793c7f5620008bc94f4
😎 Deploy Preview https://deploy-preview-1906--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: capri-xiyue
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 26, 2025
Copy link
Contributor

@liu-cong liu-cong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @JeffLuoo Did we decide to deprecate monitoring.gke.enabled and use provider:gke to enable GKE monitoring?

@capri-xiyue Note we set monitoring.gke in llm-d user guides today, but I assume deprecating it just means monitoring.gke becomes a noop right?

kubernetes.io/service-account.name: {{ $metricsReadSA }}
type: kubernetes.io/service-account-token
---
apiVersion: monitoring.googleapis.com/v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note this is only used in GKE (and therefore it was in gke.yaml)

Copy link
Contributor

@nirrozenbaum nirrozenbaum Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. for resources that are gke specific, it's preferred to have it in a separate gke.yaml file.
now we just need to change the conditional, so instead of checking gke.enabled, we might check for provider.name == gke

@ahg-g
Copy link
Contributor

ahg-g commented Nov 26, 2025

cc @JeffLuoo Did we decide to deprecate monitoring.gke.enabled and use provider:gke to enable GKE monitoring?

Yes, there is already a deprecation note. We need to update the guides in GKE, the previous release now supports both, so we can safely migrate the guide.

@capri-xiyue capri-xiyue changed the title refactor: refactor monitoring session WIP: refactor: refactor monitoring session Nov 26, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants