-
Notifications
You must be signed in to change notification settings - Fork 206
Conformance: Adds Report for kgateway #1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
cc: @robscott |
robscott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danehans!
| 8. View and verify the conformance report: | ||
|
|
||
| ```sh | ||
| cat _test/conformance/inference-$VERSION-report.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the _ intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, from the kgateway Makefile:
...
TEST_ASSET_DIR ?= $(ROOTDIR)/_test
...
.PHONY: gie-conformance
gie-conformance: gie-crds ## Run the Gateway API Inference Extension conformance suite
@mkdir -p $(TEST_ASSET_DIR)/conformance
...|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Daneyon Hansen <[email protected]>
7a8cbae to
aade24a
Compare
|
/lgtm |
Adds a conformance report for kgateway and reproducer steps.