-
Notifications
You must be signed in to change notification settings - Fork 195
Refactor the configuration defaults handling code #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @shmuelk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/ok-to-test |
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
2985d42 to
6169b66
Compare
|
/cc @ahg-g |
| if err = validateSchedulingProfiles(config); err != nil { | ||
| setDefaultsPhaseTwo(rawConfig, handle) | ||
|
|
||
| logger.Info("Configuration with defaults set", "config", rawConfig) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, so here we have the defaulted configuration logged with one exception, the plugins parameters defaults.
|
/lgtm Thanks, much better than before. Ideally the plugins parameters defaults are included somehow and logged as well |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, shmuelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR refactors the code that sets the various defaults in the loaded configuration.
In particular this PR:
In addition various configurations in the code base have been modified to remove from them default "items".
Fix: #1169