Skip to content

fix(helm): missing quotes on container arguments when extraArgs is a map #6284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vflaux wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(helm): missing quotes on container arguments when extraArgs is a map #6284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/external-dns/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Avoid creating cluster-scoped RBAC for Gateway API sources when running namespaced with `gatewayNamespace` set. Namespace listing permissions are now only added when `gatewayNamespace` is unset. ([#5843](https://github.com/kubernetes-sigs/external-dns/pull/5843)) _@TobyTheHutt_
- Ensure container arguments are passed in as strings when extraArgs is a map ([#6284](https://github.com/kubernetes-sigs/external-dns/pull/6284)) _@vflaux_

## [v1.20.0]

Expand Down
6 changes: 3 additions & 3 deletions charts/external-dns/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,13 @@ spec:
{{- if not (kindIs "invalid" $value) }}
{{- if kindIs "slice" $value }}
{{- range $value }}
- --{{ $key }}={{ tpl (. | toString) $ }}
- {{ print "--" $key "=" (tpl (. | toString) $) | quote }}
{{- end }}
{{- else }}
- --{{ $key }}={{ tpl ($value | toString) $ }}
- {{ print "--" $key "=" (tpl ($value | toString) $) | quote }}
{{- end }}
{{- else }}
- --{{ $key }}
- {{ print "--" $key | quote }}
{{- end }}
{{- end }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions charts/external-dns/tests/deployment-flags_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ tests:
extraArgC:
- valueC-1
- valueC-2
extraArgD: "valueD: D"

asserts:
- equal:
Expand All @@ -155,6 +156,7 @@ tests:
- --extraArgB=valueB
- --extraArgC=valueC-1
- --extraArgC=valueC-2
- "--extraArgD=valueD: D"


- it: should throw error when txtPrefix and txtSuffix are set
Expand Down
Loading