Skip to content

chore(set-identifier): expand annotation docs and add test coverage#6230

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
gofogo:fix-4494-identifier
Mar 16, 2026
Merged

chore(set-identifier): expand annotation docs and add test coverage#6230
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
gofogo:fix-4494-identifier

Conversation

@ivankatliarchuk
Copy link
Copy Markdown
Member

@ivankatliarchuk ivankatliarchuk commented Feb 27, 2026

What does it do ?

  • Added test coverage for set identifier, to make sure we have a baseline
  • Updated documentation with examples, notes and cross-reference

Follow-up:

Motivation

Relates #4494

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

…or dedup and merge behaviour

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2026
@k8s-ci-robot k8s-ci-robot requested a review from szuecs February 27, 2026 08:47
@k8s-ci-robot k8s-ci-robot added source size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2026
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 23110656995

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.676%

Totals Coverage Status
Change from base Build 23098157121: 0.0%
Covered Lines: 16599
Relevant Lines: 20833

💛 - Coveralls

@mloiseleur
Copy link
Copy Markdown
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2026
@ivankatliarchuk
Copy link
Copy Markdown
Member Author

/test pull-external-dns-unit-test

@ivankatliarchuk
Copy link
Copy Markdown
Member Author

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2026
@k8s-ci-robot k8s-ci-robot merged commit 6cb3fba into kubernetes-sigs:master Mar 16, 2026
18 checks passed
@ivankatliarchuk ivankatliarchuk deleted the fix-4494-identifier branch March 16, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants