feat(pihole)!: deprecate v5 API support#6123
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Jan 25, 2026
Merged
feat(pihole)!: deprecate v5 API support#6123k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
k8s-ci-robot
added
size/M
Pull Request Test Coverage Report for Build 21092247306Details
💛 - Coveralls |
Contributor
|
@u-kai: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk, u-kai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ivankatliarchuk
added a commit
to gofogo/k8s-sigs-external-dns-fork
that referenced
this pull request
Feb 1, 2026
…_total * master: chore(deps): bump mkdocs-git-revision-date-localized-plugin (kubernetes-sigs#6161) fix(annotations): initialize annotation keys at declaration time (kubernetes-sigs#6159) chore(linter): unused params and functions linter (kubernetes-sigs#6142) docs(fqdn): use correct arguments order in FQDN Templating custom functions (kubernetes-sigs#6144) chore(cloudflare): improve tests (kubernetes-sigs#6150) refactor(kubeclient): consolidate duplicate code (kubernetes-sigs#6076) remove call to get latest kubectl (kubernetes-sigs#6148) refactor(aws): extract and restructure alias-handling logic to enable safe upcoming fixes (kubernetes-sigs#6021) feat(pihole): deprecate v5 API support (kubernetes-sigs#6123) chore(cloudflare): move custom hostnames logic to dedicated files (kubernetes-sigs#6114) chore(provider): zone cache provider interface (kubernetes-sigs#6120)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ?
Pihole v5 was last released with hot fix in
Dec 29, 2024aka 2+ years ago. Those who want to stay on software that is working but not patched and no longer supported, they should pin current version of external-dns. There is no point to support both versions. Release page https://github.com/pi-hole/pi-hole/releases?page=2After the next release, we will:
--pihole-api-versionflagv5APIMotivation
Pi-hole v5 is end-of-life. Dropping v5 support simplifies maintenance and lets us focus on the current Pi-hole v6 API.
More