docs(source): autogenerate docs for events#6119
docs(source): autogenerate docs for events#6119k8s-ci-robot merged 8 commits intokubernetes-sigs:masterfrom
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Pull Request Test Coverage Report for Build 21206677659Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
54b559f to
2ecead1
Compare
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
| // +externaldns:source:filters= | ||
| // +externaldns:source:namespace=all,single | ||
| // +externaldns:source:fqdn-template=false | ||
| // +externaldns:source:events=false|true |
There was a problem hiding this comment.
Could you also add this in the Annotation Reference section?
There was a problem hiding this comment.
Added. Will think of how to make sure docs and code is in sync for this section
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does it do ?
Autogenerate docs for sources that do or do not support events. Added few example annotations.
Follow-up PR https://github.com/kubernetes-sigs/external-dns/pull/6099/changes#diff-11a48066892ef7176ddc61b21bcc6b421a62c745702e8b8a3948cf456daf8362
Motivation
Autogenerate docs for sources
More