Skip to content

chore(deps): tools bump and process in contributor docs#6118

Merged
k8s-ci-robot merged 8 commits intokubernetes-sigs:masterfrom
gofogo:chore-deps-tools
Mar 20, 2026
Merged

chore(deps): tools bump and process in contributor docs#6118
k8s-ci-robot merged 8 commits intokubernetes-sigs:masterfrom
gofogo:chore-deps-tools

Conversation

@ivankatliarchuk
Copy link
Copy Markdown
Member

@ivankatliarchuk ivankatliarchuk commented Jan 16, 2026

What does it do ?

The PR where workflow was initially introduced #6079

  • go.tool.sum retains old hashes alongside new ones — standard Go behavior for sum files.

I did run mk update-tools-deps & mk crd as current workflow. This is not a go.tool.sum cleanup.

Motivation

Closes #6106

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 16, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 16, 2026

Pull Request Test Coverage Report for Build 23220727986

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 78.277%

Files with Coverage Reduction New Missed Lines %
openshift_route.go 1 83.59%
Totals Coverage Status
Change from base Build 23200578618: -0.005%
Covered Lines: 16363
Relevant Lines: 20904

💛 - Coveralls

@vflaux
Copy link
Copy Markdown
Contributor

vflaux commented Jan 24, 2026

Wdyt about moving go.tools.* to a dedicated folder (e.g. tools)?
This would allow running go mod tidy on this file, ensuring a clean go.mod (it removes some packages from the go.mod file).
Running a tool would look like this: go -C tools tool yq.
I’m also wondering whether Dependabot would work on this file too.

@ivankatliarchuk
Copy link
Copy Markdown
Member Author

ivankatliarchuk commented Jan 24, 2026

There are multiple tools supported

tool (
	github.com/google/yamlfmt/cmd/yamlfmt
	github.com/mikefarah/yq/v4
	sigs.k8s.io/controller-tools/cmd/controller-gen
)

Could you share any docs recomending moving go.tool.mod from the root?

@ivankatliarchuk
Copy link
Copy Markdown
Member Author

ivankatliarchuk commented Jan 24, 2026

I shared in previous PR dependabot/dependabot-core#12050. At some point the Dependabot will support tools directives they way it should

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk
Copy link
Copy Markdown
Member Author

updated docs

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk
Copy link
Copy Markdown
Member Author

/retitle chore(deps): tools bump and process in contributor docs

@k8s-ci-robot k8s-ci-robot changed the title chore(deps): tools bump chore(deps): tools bump and process in contributor docs Mar 11, 2026
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2026
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Copy link
Copy Markdown
Collaborator

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2026
@ivankatliarchuk
Copy link
Copy Markdown
Member Author

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2026
@k8s-ci-robot k8s-ci-robot merged commit 1c9913b into kubernetes-sigs:master Mar 20, 2026
19 checks passed
@ivankatliarchuk ivankatliarchuk deleted the chore-deps-tools branch March 20, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request new release including Go security fixes for golang.org/x/crypto and stdlib vulnerabilities

5 participants