Skip to content

test(fqdn): cover sources without any fqdn tests #6094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 3 commits into from
Jan 15, 2026
Merged

test(fqdn): cover sources without any fqdn tests #6094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26c062c
chore(fqdn): added fqdn specific tests for sources
ivankatliarchuk Jan 10, 2026
941ba58
Merge branch 'master' into chore-fqdn-add-tests
ivankatliarchuk Jan 10, 2026
64f3182
chore(fqdn): added fqdn specific tests for sources
ivankatliarchuk Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/endpoints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ func EndpointsForHostname(hostname string, targets endpoint.Targets, ttl endpoin
return endpoints
}

// EndpointTargetsFromServices retrieves endpoint targets from services in a given namespace
// that match the specified selector. It returns external IPs or load balancer addresses.
//
// TODO: add support for service.Spec.Ports (type NodePort) and service.Spec.ClusterIPs (type ClusterIP)
func EndpointTargetsFromServices(svcInformer coreinformers.ServiceInformer, namespace string, selector map[string]string) (endpoint.Targets, error) {
targets := endpoint.Targets{}

Expand Down
10 changes: 5 additions & 5 deletions source/istio_gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func (sc *gatewaySource) Endpoints(ctx context.Context) ([]*endpoint.Endpoint, e

log.Debugf("Processing gateway '%s/%s.%s' and hosts %q", gateway.Namespace, gateway.APIVersion, gateway.Name, strings.Join(gwHostnames, ","))

gwEndpoints, err := sc.endpointsFromGateway(ctx, gwHostnames, gateway)
gwEndpoints, err := sc.endpointsFromGateway(gwHostnames, gateway)
if err != nil {
return nil, err
}
Expand All @@ -183,7 +183,7 @@ func (sc *gatewaySource) Endpoints(ctx context.Context) ([]*endpoint.Endpoint, e
if err != nil {
return nil, err
}
return sc.endpointsFromGateway(ctx, hostnames, gateway)
return sc.endpointsFromGateway(hostnames, gateway)
},
)
if err != nil {
Expand Down Expand Up @@ -240,7 +240,7 @@ func (sc *gatewaySource) targetsFromIngress(ingressStr string, gateway *networki
return targets, nil
}

func (sc *gatewaySource) targetsFromGateway(ctx context.Context, gateway *networkingv1beta1.Gateway) (endpoint.Targets, error) {
func (sc *gatewaySource) targetsFromGateway(gateway *networkingv1beta1.Gateway) (endpoint.Targets, error) {
targets := annotations.TargetsFromTargetAnnotation(gateway.Annotations)
if len(targets) > 0 {
return targets, nil
Expand All @@ -255,11 +255,11 @@ func (sc *gatewaySource) targetsFromGateway(ctx context.Context, gateway *networ
}

// endpointsFromGatewayConfig extracts the endpoints from an Istio Gateway Config object
func (sc *gatewaySource) endpointsFromGateway(ctx context.Context, hostnames []string, gateway *networkingv1beta1.Gateway) ([]*endpoint.Endpoint, error) {
func (sc *gatewaySource) endpointsFromGateway(hostnames []string, gateway *networkingv1beta1.Gateway) ([]*endpoint.Endpoint, error) {
var endpoints []*endpoint.Endpoint
var err error

targets, err := sc.targetsFromGateway(ctx, gateway)
targets, err := sc.targetsFromGateway(gateway)
if err != nil {
return nil, err
}
Expand Down
Loading
Loading