refactor(annotation): rationalize filtering

[ivankatliarchuk]

What does it do ?

While was reviewing issues, found that multiple sources do use they own annotation filter methods....

Follow-up:

• example

  external-dns/source/pod.go

  Line 70 in 2bdb8df

  err := podInformer.Informer().AddIndexers(informers.IndexerWithOptions[*corev1.Pod](

  refactore to use informers. Not all sources do support informers. Informers way faster + massive memory decrease. I'll wait if there are going to be no bugs declared, will implement for other sources if they do support it. Example PR feat(source/pods): support for annotation and label filter #5583

Motivation

• Ensures consistency across all sources
• Single location for bug fixes/improvements
• Easier to test comprehensively

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[coveralls]

Pull Request Test Coverage Report for Build 20595903827

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 289 unchanged lines in 20 files lost coverage.
• Overall coverage decreased (-0.08%) to 78.84%

---

Files with Coverage Reduction	New Missed Lines	%
gateway_udproute.go	2	92.59%
gateway_grpcroute.go	2	92.59%
gateway_tlsroute.go	2	92.59%
node.go	2	92.42%
gateway_httproute.go	2	92.59%
gateway_tcproute.go	2	92.59%
source.go	2	72.22%
openshift_route.go	3	85.0%
gateway_hostname.go	4	42.86%
contour_httpproxy.go	7	84.35%

Totals
Change from base Build 20594269099:	-0.08%
Covered Lines:	15787
Relevant Lines:	20024

---

💛 - Coveralls

[mloiseleur]

Very nice PR. Thanks @ivankatliarchuk 👍
/lgtm

[ivankatliarchuk]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ivankatliarchuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment