Skip to content

test: fix typos in code & comment #6011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Dec 10, 2025
+7 −7
Merged

test: fix typos in code & comment #6011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/apis/externaldns/types_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,7 @@ func TestParseFlagsCliFlagSeparatedValue(t *testing.T) {
assert.ElementsMatch(t, []string{"service"}, cfg.Sources)
}

// Env vars are accpeted by Kingpin backend but ignored by Cobra
// Env vars are accepted by Kingpin backend but ignored by Cobra
func TestEnvVarsIgnoredByCobraBackend(t *testing.T) {
t.Setenv("EXTERNAL_DNS_CLI", "cobra")
t.Setenv("EXTERNAL_DNS_NAMESPACE", "ns-from-env")
Expand Down
12 changes: 6 additions & 6 deletions source/gateway_httproute_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1329,7 +1329,7 @@ func TestGatewayHTTPRouteSourceEndpoints(t *testing.T) {
gateways: []*v1beta1.Gateway{
{
ObjectMeta: metav1.ObjectMeta{
Name: "overriden-gateway",
Name: "overridden-gateway",
Namespace: "gateway-namespace",
Annotations: map[string]string{
annotations.TargetKey: "4.3.2.1",
Expand All @@ -1350,12 +1350,12 @@ func TestGatewayHTTPRouteSourceEndpoints(t *testing.T) {
Hostnames: hostnames("test.example.internal"),
CommonRouteSpec: v1.CommonRouteSpec{
ParentRefs: []v1.ParentReference{
gwParentRef("gateway-namespace", "overriden-gateway"),
gwParentRef("gateway-namespace", "overridden-gateway"),
},
},
},
Status: httpRouteStatus( // The route is attached to both gateways.
gwParentRef("gateway-namespace", "overriden-gateway"),
gwParentRef("gateway-namespace", "overridden-gateway"),
),
}},
endpoints: []*endpoint.Endpoint{
Expand All @@ -1371,7 +1371,7 @@ func TestGatewayHTTPRouteSourceEndpoints(t *testing.T) {
gateways: []*v1beta1.Gateway{
{
ObjectMeta: metav1.ObjectMeta{
Name: "overriden-gateway",
Name: "overridden-gateway",
Namespace: "gateway-namespace",
Annotations: map[string]string{
annotations.TargetKey: "4.3.2.1",
Expand Down Expand Up @@ -1402,13 +1402,13 @@ func TestGatewayHTTPRouteSourceEndpoints(t *testing.T) {
Hostnames: hostnames("test.example.internal"),
CommonRouteSpec: v1.CommonRouteSpec{
ParentRefs: []v1.ParentReference{
gwParentRef("gateway-namespace", "overriden-gateway"),
gwParentRef("gateway-namespace", "overridden-gateway"),
gwParentRef("gateway-namespace", "test"),
},
},
},
Status: httpRouteStatus(
gwParentRef("gateway-namespace", "overriden-gateway"),
gwParentRef("gateway-namespace", "overridden-gateway"),
gwParentRef("gateway-namespace", "test"),
),
}},
Expand Down
Loading