Skip to content

fix(coredns): debug message on labels update #5789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 2 commits into from
Sep 3, 2025
Merged

fix(coredns): debug message on labels update #5789

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c3b06d
coredns: fix debug message
bachorp Sep 1, 2025
eaad733
consistent spacing in debug message
bachorp Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion provider/coredns/coredns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,8 @@ func (p coreDNSProvider) groupEndpoints(changes *plan.Changes) map[string][]*end
grouped[ep.DNSName] = append(grouped[ep.DNSName], ep)
}
for i, ep := range changes.UpdateNew {
ep.Labels = changes.UpdateOld[i].Labels
log.Debugf("Updating labels (%s) with old labels(%s)", ep.Labels, changes.UpdateOld[i].Labels)
Comment thread
bachorp marked this conversation as resolved.
Outdated
ep.Labels = changes.UpdateOld[i].Labels
grouped[ep.DNSName] = append(grouped[ep.DNSName], ep)
}
return grouped
Expand Down
Loading