Skip to content

refactor: use slices.Contains instead of handrolled for loop #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Jun 29, 2025
+4 −10
Merged

refactor: use slices.Contains instead of handrolled for loop #5589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions plan/plan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package plan

import (
"fmt"
"slices"
"strings"

"github.com/google/go-cmp/cmp"
Expand Down Expand Up @@ -353,15 +354,8 @@ func normalizeDNSName(dnsName string) string {
}

func IsManagedRecord(record string, managedRecords, excludeRecords []string) bool {
for _, r := range excludeRecords {
if record == r {
return false
}
}
for _, r := range managedRecords {
if record == r {
return true
}
if slices.Contains(excludeRecords, record) {
return false
}
return false
return slices.Contains(managedRecords, record)
}
Loading