-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(chart): add missing changelog for #5493 #5541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): add missing changelog for #5493 #5541
Conversation
|
Hi @vflaux. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vflaux the chart Changelog is for explicit chart changes not ExternalDNS changes, any changes to the ExternalDNS code would be expected to be implied by a image version change entry.
74af991 to
f8670d8
Compare
|
There is changes in the rbac for service source in #5493. |
e83af56 to
dd5d1b5
Compare
|
Thanks for this @vflaux. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does it do ?
Add a missing changelog record in the chart for #5493
Motivation
More