Skip to content

test(metrics): replace random value with a static value#5462

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
u-kai:fix/flaky-test
May 25, 2025
Merged

test(metrics): replace random value with a static value#5462
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
u-kai:fix/flaky-test

Conversation

@u-kai
Copy link
Copy Markdown
Member

@u-kai u-kai commented May 25, 2025

What does it do ?

This PR replaces the randomly generated Subsystem names in internal/gen/docs/metrics/main_test.go with static, unique values.

Previously, rand.IntN(100) was used to reduce the chance of collision, but this still introduced a 1% chance of flaky test failures due to duplicate names.

Motivation

In #5459, we discussed improving test stability by adding +100 to the second rand.IntN call.
While that suggestion would reduce the collision probability, I opted for static values instead.
This eliminates the chance of collision entirely and ensures that if a conflicting test is added in the future, it will fail deterministically and be immediately detectable during development or CI.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @u-kai. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2025
@mloiseleur
Copy link
Copy Markdown
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2025
@mloiseleur mloiseleur changed the title fix(gen/docs/metrics/main_test): flaky test by replacing random value with a static value test(metrics): replace random value with a static value May 25, 2025
Copy link
Copy Markdown
Member

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2025
@mloiseleur
Copy link
Copy Markdown
Collaborator

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 186e57e into kubernetes-sigs:master May 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants