Skip to content

fix(gateway-api): ensure to use only latest generation with HTTPRoutes #5349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 10, 2025
Merged

fix(gateway-api): ensure to use only latest generation with HTTPRoutes #5349

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
219e19f
fix: check that parent generation matches current generation.
kashalls May 3, 2025
1ad804c
fix: add unit tests for generation check
tholinka May 3, 2025
11ca783
Merge pull request #1 from tholinka/fix-gateway-maybe
kashalls May 3, 2025
0dcd6c9
chore: move into pre-existing conditions check
kashalls May 3, 2025
059daad
chore: remove unneccessary new line
kashalls May 3, 2025
57ba990
fix: add unit test for route never being accepted
tholinka May 4, 2025
e5f584f
Merge pull request #2 from tholinka/fix-gateway-maybe
kashalls May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source/gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,13 @@ func (c *gatewayRouteResolver) resolve(rt gatewayRoute) (map[string]endpoint.Tar
for _, rps := range rt.RouteStatus().Parents {
// Confirm the Parent is the standard Gateway kind.
ref := rps.ParentRef

namespace := strVal((*string)(ref.Namespace), meta.Namespace)
if rps.Conditions[0].ObservedGeneration != meta.Generation {
log.Debugf("Ignoring parent %s/%s of %s/%s as generation %d does not match current generation %d", namespace, ref.Name, meta.Namespace, meta.Name, rps.Conditions[0].ObservedGeneration, meta.Generation)
continue
}

// Ensure that the parent reference is in the routeParentRefs list
if !gwRouteHasParentRef(routeParentRefs, ref, meta) {
log.Debugf("Parent reference %s/%s not found in routeParentRefs for %s %s/%s", namespace, string(ref.Name), c.src.rtKind, meta.Namespace, meta.Name)
Expand Down
Loading