chore(helm): add validation for prefix and suffix and capture regression

charts/external-dns/templates/deployment.yaml

@@ -103,7 +103,7 @@ spec:
             {{- if .Values.txtPrefix }}
             - --txt-prefix={{ .Values.txtPrefix }}
             {{- end }}
-            {{- if and (eq .Values.txtPrefix "") (ne .Values.txtSuffix "") }}
+            {{- if and (not (empty .Values.txtSuffix)) (empty .Values.txtPrefix) }}
             - --txt-suffix={{ .Values.txtSuffix }}
             {{- end }}
             {{- if .Values.namespaced }}

charts/external-dns/templates/validation.tpl

@@ -0,0 +1,6 @@
+{{/*
+Mutually exclusive txtPrefix and txtSuffix
+*/}}
+{{- if and .Values.txtPrefix .Values.txtSuffix -}}
+  {{- fail (printf "'txtPrefix' and 'txtSuffix' mutually exclusive") -}}
+{{- end -}}

charts/external-dns/tests/deployment-flags_test.yaml

@@ -6,7 +6,6 @@ release:
 tests:
   - it: should provide expected default flags
     asserts:
-      # - matchSnapshot: {}
       - exists :
           path: spec.template.spec.containers[?(@.name == "external-dns")]
       - equal :
@@ -71,6 +70,16 @@ tests:
           path: spec.template.spec.containers[?(@.name == "external-dns")].args
           content: "--txt-prefix=test-prefix"
 
+  - it: should configure 'txtSuffix' when set and 'txtPrefix' is not present
+    set:
+      txtSuffix: "custom-suffix"
+    asserts:
+      - exists :
+          path: spec.template.spec.containers[?(@.name == "external-dns")]
+      - contains:
+          path: spec.template.spec.containers[?(@.name == "external-dns")].args
+          content: "--txt-suffix=custom-suffix"
+
   - it: should be able configure multiple sources
     set:
       sources:

charts/external-dns/tests/validation_test.yaml

@@ -0,0 +1,37 @@
+suite: Test team namespace constraints
+templates:
+  - validation.tpl
+tests:
+  - it: should fail when txtPrefix and txtSuffix are set
+    templates:
+      - validation.tpl
+    set:
+        txtPrefix: "test-prefix"
+        txtSuffix: "test-suffix"
+        txtOwnerId: "testing"
+    asserts:
+      - failedTemplate:
+          errorMessage: "'txtPrefix' and 'txtSuffix' mutually exclusive"
+
+  - it: should not fail when txtPrefix is set
+    templates:
+      - validation.tpl
+    set:
+        txtPrefix: "test-prefix"
+        txtSuffix: ""
+    asserts:
+      - notFailedTemplate: {}
+
+  - it: should not fail when txtSuffix is set
+    templates:
+      - validation.tpl
+    set:
+        txtSuffix: "abrakadabra"
+    asserts:
+      - notFailedTemplate: {}
+
+  - it: should not fail with default values
+    templates:
+      - validation.tpl
+    asserts:
+      - notFailedTemplate: {}