fix(cloudflare): infinite loop with more than 50 custom hostnames #5181

mrozentsvayg · 2025-03-14T02:27:32Z

…number of custom hostnames more than 50

Description

Fixes #ISSUE

Checklist

Unit tests updated
End user documentation updated

…number of custom hostnames more than 50

k8s-ci-robot · 2025-03-14T02:27:42Z

Hi @mrozentsvayg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mrozentsvayg · 2025-03-14T02:33:10Z

This one is important to include with 0.16.1 if possible, I believe.

Not currently implemented paging support for CustomHostnames() tests implementation contributed into not detecting this bug timely.
I'm going to add it, but we might want to merge this PR sooner than that.

mloiseleur · 2025-03-14T07:43:00Z

/retitle fix(cloudflare): infinite loop with more than 50 hostnames

mloiseleur · 2025-03-14T07:43:22Z

@mrozentsvayg ~~Do you think you can add a test on this, so we can avoid to face it again in the future ?~~

EDIT: Nevermind, we will see that with paging.

mloiseleur · 2025-03-14T07:43:41Z

/retitle fix(cloudflare): infinite loop with more than 50 custom hostnames

mloiseleur · 2025-03-14T11:18:47Z

@mrozentsvayg How about adding this known limit in the documentation ?

ivankatliarchuk · 2025-03-14T13:24:02Z

Tests are missing. I have a similar use case, where need to test for 100+ zones. Here is how I did it, worth to duplicate for cloudflare? https://github.com/kubernetes-sigs/external-dns/blob/master/provider/aws/aws_fixtures_test.go

mrozentsvayg · 2025-03-14T15:08:55Z

@mrozentsvayg How about adding this known limit in the documentation ?

Do you mean hardcoded 50 results per-page in the cloudflare-go v0 api that we are currently using?
I can add it if you think it would be useful.

By the way, are there any known blockers preventing migration to a newer api ?

mrozentsvayg · 2025-03-14T15:13:02Z

Tests are missing. I have a similar use case, where need to test for 100+ zones. Here is how I did it, worth to duplicate for cloudflare? https://github.com/kubernetes-sigs/external-dns/blob/master/provider/aws/aws_fixtures_test.go

Test is easy, I drafted it yesterday. Implementing the paging specifically for the test (https://github.com/kubernetes-sigs/external-dns/blob/master/provider/cloudflare/cloudflare_test.go#L262-L282) is what I didn't yesterday have time for.
I'll do it today, hopefully there's still time to push it before the next release.

ivankatliarchuk · 2025-03-14T15:52:08Z

By the way, are there any known blockers preventing migration to a newer api ?

I think we should have at least a single stable cloudflare release first. And resolve this 2 issues

ivankatliarchuk · 2025-03-14T15:53:16Z

Do you mean hardcoded 50 results per-page in the cloudflare-go v0 api that we are currently using? I can add it if you think it would be useful.

It sounds useful. Basically we do not want to test it manually every time, and having a unit tests for paging should help at least a bit. Plus as you mention, if planning to bump an SDK version, we should have a coverage for such things

mrozentsvayg · 2025-03-14T16:47:39Z

added pagination support for custom hostnames tests
added test for paging, it would correctly hang with before-the-fix code
added information about custom hostnames page size to the doc

ivankatliarchuk · 2025-03-14T16:54:38Z

/label tide/merge-method-squash

ivankatliarchuk · 2025-03-14T16:55:38Z

Have you had a chance to test changes against a real cloudflare account?

ivankatliarchuk · 2025-03-14T16:56:06Z

/ok-to-test

mrozentsvayg · 2025-03-14T16:56:35Z

Have you had a chance to test changes against a real cloudflare account?

I am running this exact build in production with hundreds of Cloudflare records and custom hostnames.

ivankatliarchuk

/lgtm

mloiseleur

342 custom hostname seems a reasonable amount to test: )

k8s-ci-robot · 2025-03-14T17:22:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…bernetes-sigs#5181) * bugfix - do not reset the resultInfo var, causing infinite loop when number of custom hostnames more than 50 * support paging for custom hostnames tests; update doc

fix(registry): improve logging for TXT records with empty targets and add unit test test(registry): enhance logging for empty targets in TXT records test Test author (#1) * fix(aws-sd): service instances registration and deregistration (kubernetes-sigs#5135) * Only de-register removed targets * Use maps for current targets lookup. * Use camelCase, not _ * fix(registry): handle empty targets in TXT records logging an error * fix(registry): improve logging for TXT records with empty targets and add unit test * test(registry): enhance logging for empty targets in TXT records test fix: add mexico region to external dns supported load balancers (kubernetes-sigs#5157) add: auto label source and providers Signed-off-by: Sandor Szuecs <[email protected]> feat(source): fitler by gateway name (kubernetes-sigs#5160) * feat: filter by gateway name Signed-off-by: Steven Kreitzer <[email protected]> * address comments * address comments * address comments --------- Signed-off-by: Steven Kreitzer <[email protected]> chore: update OWNERs with left required config file cloudflare: bugfix - do not attempt to create unconfigured empty custom hostnames; improve tests; streamline logic (kubernetes-sigs#5146) improve test coverage test the edge case when the custom hostname has changed during the record deletion don't use custom hostnames if Cloudflare for SaaS fails to authenticate Use new --cloudflare-custom-hostnames flag to enable cloudflare custom hostnames support custom hostnames flags --cloudflare-custom-hostnames-min-tls-version and --cloudflare-custom-hostnames-certificate-authority support markdown lint Update cloudflare.md fix(source): config didnt set gatewayname fix(cloudflare): infinite loop with more than 50 custom hostnames (kubernetes-sigs#5181) * bugfix - do not reset the resultInfo var, causing infinite loop when number of custom hostnames more than 50 * support paging for custom hostnames tests; update doc chore(release): updates kustomize & docs with v0.16.1 Signed-off-by: Michel Loiseleur <[email protected]> update release script update release instructions chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(openstack designate)!: remove in-tree provider Add Yandex Cloud Webhook feat(ovh): major rewriting of the provider (kubernetes-sigs#5143) * feat: ovh: improve cache invalidation on errors + dry-run mode + relative CNAME handling + optimization Signed-off-by: Romain Beuque <[email protected]> * chore: add more tests Signed-off-by: Romain Beuque <[email protected]> * fix: align cache expiration with Default value * chore: address comments from review + updated documentation * chore: address comments from review --------- Signed-off-by: Romain Beuque <[email protected]> chore(deps): bump renovatebot/github-action Bumps the dev-dependencies group with 1 update: [renovatebot/github-action](https://github.com/renovatebot/github-action). Updates `renovatebot/github-action` from 41.0.14 to 41.0.16 - [Release notes](https://github.com/renovatebot/github-action/releases) - [Changelog](https://github.com/renovatebot/github-action/blob/main/CHANGELOG.md) - [Commits](renovatebot/github-action@v41.0.14...v41.0.16) --- updated-dependencies: - dependency-name: renovatebot/github-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> feat(chart): Update image to v0.16.1 Signed-off-by: Steve Hipwell <[email protected]> chore(deps): bump renovatebot/github-action Bumps the dev-dependencies group with 1 update: [renovatebot/github-action](https://github.com/renovatebot/github-action). Updates `renovatebot/github-action` from 41.0.16 to 41.0.17 - [Release notes](https://github.com/renovatebot/github-action/releases) - [Changelog](https://github.com/renovatebot/github-action/blob/main/CHANGELOG.md) - [Commits](renovatebot/github-action@v41.0.16...v41.0.17) --- updated-dependencies: - dependency-name: renovatebot/github-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> feat: IDNA awareness in the zone finder (kubernetes-sigs#5147) * feat: IDNA awareness in the zone finder * feat: update zonefinder unit tests * chore: add warning log and respective test feat(banner): standardize user agent and output (kubernetes-sigs#5154) * chore(banner): add banner Signed-off-by: ivan katliarchuk <[email protected]> * chore(banner): add banner Signed-off-by: ivan katliarchuk <[email protected]> * chore(banner): add banner Signed-off-by: ivan katliarchuk <[email protected]> * chore(banner): add banner Signed-off-by: ivan katliarchuk <[email protected]> * feat(banner): standartise user agent and output banner Signed-off-by: ivan katliarchuk <[email protected]> --------- Signed-off-by: ivan katliarchuk <[email protected]> fix(cloudflare): custom hostnames edge-cases causing duplicates (kubernetes-sigs#5183) * fix(cloudflare): custom hostnames edge-cases causing duplicates * syntax/style * Use %q log fmt for cloudflare provider code * move custom hostnames related submitChanges() implementation to a separate method submitCustomHostnameChanges(); extend truncated logging * use maps for DNS records getRecordID() and custom hostnames getCustomHostname() for faster lookups * types for records/custom hostnames maps * tidy up using underlying maps for dns records and custom hostnames * style/naming * fix private names * combine unnecessarily separated conditions fix: correct route53 iam chore(deps): bump the dev-dependencies group across 1 directory with 20 updates Bumps the dev-dependencies group with 16 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/Azure/azure-sdk-for-go/sdk/azcore](https://github.com/Azure/azure-sdk-for-go) | `1.17.0` | `1.17.1` | | [github.com/IBM-Cloud/ibm-cloud-cli-sdk](https://github.com/IBM-Cloud/ibm-cloud-cli-sdk) | `1.6.2` | `1.7.0` | | [github.com/IBM/go-sdk-core/v5](https://github.com/IBM/go-sdk-core) | `5.18.5` | `5.19.0` | | [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) | `1.63.92` | `1.63.100` | | [github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue](https://github.com/aws/aws-sdk-go-v2) | `1.18.7` | `1.18.8` | | [github.com/aws/aws-sdk-go-v2/service/route53](https://github.com/aws/aws-sdk-go-v2) | `1.49.1` | `1.50.0` | | [github.com/civo/civogo](https://github.com/civo/civogo) | `0.3.94` | `0.3.95` | | [github.com/digitalocean/godo](https://github.com/digitalocean/godo) | `1.138.0` | `1.141.0` | | [github.com/miekg/dns](https://github.com/miekg/dns) | `1.1.63` | `1.1.64` | | [github.com/oracle/oci-go-sdk/v65](https://github.com/oracle/oci-go-sdk) | `65.85.0` | `65.87.0` | | [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.1115` | `1.0.1129` | | [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.1115` | `1.0.1128` | | [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) | `3.5.19` | `3.5.20` | | [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.223.0` | `0.227.0` | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.2` | `0.32.3` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.32.2` | `0.32.3` | Updates `github.com/Azure/azure-sdk-for-go/sdk/azcore` from 1.17.0 to 1.17.1 - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.17.0...sdk/azcore/v1.17.1) Updates `github.com/IBM-Cloud/ibm-cloud-cli-sdk` from 1.6.2 to 1.7.0 - [Release notes](https://github.com/IBM-Cloud/ibm-cloud-cli-sdk/releases) - [Commits](IBM-Cloud/ibm-cloud-cli-sdk@v1.6.2...v1.7.0) Updates `github.com/IBM/go-sdk-core/v5` from 5.18.5 to 5.19.0 - [Release notes](https://github.com/IBM/go-sdk-core/releases) - [Changelog](https://github.com/IBM/go-sdk-core/blob/main/CHANGELOG.md) - [Commits](IBM/go-sdk-core@v5.18.5...v5.19.0) Updates `github.com/aliyun/alibaba-cloud-sdk-go` from 1.63.92 to 1.63.100 - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.92...v1.63.100) Updates `github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue` from 1.18.7 to 1.18.8 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@config/v1.18.7...config/v1.18.8) Updates `github.com/aws/aws-sdk-go-v2/service/dynamodb` from 1.41.1 to 1.42.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/ecr/v1.41.1...service/s3/v1.42.0) Updates `github.com/aws/aws-sdk-go-v2/service/route53` from 1.49.1 to 1.50.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/ssm/v1.49.1...service/s3/v1.50.0) Updates `github.com/civo/civogo` from 0.3.94 to 0.3.95 - [Release notes](https://github.com/civo/civogo/releases) - [Changelog](https://github.com/civo/civogo/blob/master/changelog.yml) - [Commits](civo/civogo@v0.3.94...v0.3.95) Updates `github.com/digitalocean/godo` from 1.138.0 to 1.141.0 - [Release notes](https://github.com/digitalocean/godo/releases) - [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md) - [Commits](digitalocean/godo@v1.138.0...v1.141.0) Updates `github.com/miekg/dns` from 1.1.63 to 1.1.64 - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.63...v1.1.64) Updates `github.com/oracle/oci-go-sdk/v65` from 65.85.0 to 65.87.0 - [Release notes](https://github.com/oracle/oci-go-sdk/releases) - [Changelog](https://github.com/oracle/oci-go-sdk/blob/master/CHANGELOG.md) - [Commits](oracle/oci-go-sdk@v65.85.0...v65.87.0) Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common` from 1.0.1115 to 1.0.1129 - [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.1115...v1.0.1129) Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod` from 1.0.1115 to 1.0.1128 - [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.1115...v1.0.1128) Updates `go.etcd.io/etcd/client/v3` from 3.5.19 to 3.5.20 - [Release notes](https://github.com/etcd-io/etcd/releases) - [Commits](etcd-io/etcd@v3.5.19...v3.5.20) Updates `golang.org/x/net` from 0.36.0 to 0.37.0 - [Commits](golang/net@v0.36.0...v0.37.0) Updates `golang.org/x/text` from 0.22.0 to 0.23.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.22.0...v0.23.0) Updates `google.golang.org/api` from 0.223.0 to 0.227.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.223.0...v0.227.0) Updates `k8s.io/api` from 0.32.2 to 0.32.3 - [Commits](kubernetes/api@v0.32.2...v0.32.3) Updates `k8s.io/apimachinery` from 0.32.2 to 0.32.3 - [Commits](kubernetes/apimachinery@v0.32.2...v0.32.3) Updates `k8s.io/client-go` from 0.32.2 to 0.32.3 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.32.2...v0.32.3) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azcore dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/IBM-Cloud/ibm-cloud-cli-sdk dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/IBM/go-sdk-core/v5 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/dynamodb dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/route53 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/civo/civogo dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/digitalocean/godo dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/miekg/dns dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/oracle/oci-go-sdk/v65 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: go.etcd.io/etcd/client/v3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> feat: added expose internal ipv6 flag fix: removing fmt.Printf fix: fixing ci lint docs: added documentation in node source edited docs and made new test added warn log detailed documentation with no-expose added new tests to handle edge case renaming variable removing reduntant code fix(chart): add missing types for empty values (kubernetes-sigs#5207) * fix(chart): add missing types for empty values Signed-off-by: t3mi <[email protected]> * fix(chart): add one more space before comment Signed-off-by: t3mi <[email protected]> * chore: add changelog entry Signed-off-by: t3mi <[email protected]> * fix: use default value for service account token Signed-off-by: t3mi <[email protected]> * fix: tests for new default values Signed-off-by: t3mi <[email protected]> * chore: add one more changelog entry Signed-off-by: t3mi <[email protected]> --------- Signed-off-by: t3mi <[email protected]> fix(node): logger test fixed (kubernetes-sigs#5232) Signed-off-by: ivan katliarchuk <[email protected]> docs: Fix typo: grcp → grpc. chore(deps): bump the dev-dependencies group across 1 directory with 17 updates Bumps the dev-dependencies group with 15 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/IBM/networking-go-sdk](https://github.com/IBM/networking-go-sdk) | `0.51.2` | `0.51.3` | | [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) | `1.63.100` | `1.63.103` | | [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.29.9` | `1.29.12` | | [github.com/civo/civogo](https://github.com/civo/civogo) | `0.3.95` | `0.3.96` | | [github.com/digitalocean/godo](https://github.com/digitalocean/godo) | `1.141.0` | `1.142.0` | | [github.com/oracle/oci-go-sdk/v65](https://github.com/oracle/oci-go-sdk) | `65.87.0` | `65.88.0` | | [github.com/projectcontour/contour](https://github.com/projectcontour/contour) | `1.30.2` | `1.30.3` | | [github.com/scaleway/scaleway-sdk-go](https://github.com/scaleway/scaleway-sdk-go) | `1.0.0-beta.32` | `1.0.0-beta.33` | | [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.1129` | `1.0.1134` | | [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.1128` | `1.0.1134` | | [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.1115` | `1.0.1132` | | [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) | `3.5.20` | `3.5.21` | | [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.227.0` | `0.228.0` | | [istio.io/api](https://github.com/istio/api) | `1.25.0` | `1.25.1` | | [istio.io/client-go](https://github.com/istio/client-go) | `1.25.0` | `1.25.1` | Updates `github.com/IBM/networking-go-sdk` from 0.51.2 to 0.51.3 - [Release notes](https://github.com/IBM/networking-go-sdk/releases) - [Changelog](https://github.com/IBM/networking-go-sdk/blob/master/CHANGELOG.md) - [Commits](IBM/networking-go-sdk@v0.51.2...v0.51.3) Updates `github.com/aliyun/alibaba-cloud-sdk-go` from 1.63.100 to 1.63.103 - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.100...v1.63.103) Updates `github.com/aws/aws-sdk-go-v2/config` from 1.29.9 to 1.29.12 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@config/v1.29.9...config/v1.29.12) Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.17.62 to 1.17.65 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@credentials/v1.17.62...credentials/v1.17.65) Updates `github.com/civo/civogo` from 0.3.95 to 0.3.96 - [Release notes](https://github.com/civo/civogo/releases) - [Changelog](https://github.com/civo/civogo/blob/master/changelog.yml) - [Commits](civo/civogo@v0.3.95...v0.3.96) Updates `github.com/digitalocean/godo` from 1.141.0 to 1.142.0 - [Release notes](https://github.com/digitalocean/godo/releases) - [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md) - [Commits](digitalocean/godo@v1.141.0...v1.142.0) Updates `github.com/oracle/oci-go-sdk/v65` from 65.87.0 to 65.88.0 - [Release notes](https://github.com/oracle/oci-go-sdk/releases) - [Changelog](https://github.com/oracle/oci-go-sdk/blob/master/CHANGELOG.md) - [Commits](oracle/oci-go-sdk@v65.87.0...v65.88.0) Updates `github.com/projectcontour/contour` from 1.30.2 to 1.30.3 - [Release notes](https://github.com/projectcontour/contour/releases) - [Changelog](https://github.com/projectcontour/contour/blob/main/RELEASES.md) - [Commits](projectcontour/contour@v1.30.2...v1.30.3) Updates `github.com/scaleway/scaleway-sdk-go` from 1.0.0-beta.32 to 1.0.0-beta.33 - [Release notes](https://github.com/scaleway/scaleway-sdk-go/releases) - [Changelog](https://github.com/scaleway/scaleway-sdk-go/blob/master/CHANGELOG.md) - [Commits](scaleway/scaleway-sdk-go@v1.0.0-beta.32...v1.0.0-beta.33) Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common` from 1.0.1129 to 1.0.1134 - [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.1129...v1.0.1134) Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod` from 1.0.1128 to 1.0.1134 - [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.1128...v1.0.1134) Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns` from 1.0.1115 to 1.0.1132 - [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.1115...v1.0.1132) Updates `go.etcd.io/etcd/client/v3` from 3.5.20 to 3.5.21 - [Release notes](https://github.com/etcd-io/etcd/releases) - [Commits](etcd-io/etcd@v3.5.20...v3.5.21) Updates `golang.org/x/net` from 0.37.0 to 0.38.0 - [Commits](golang/net@v0.37.0...v0.38.0) Updates `google.golang.org/api` from 0.227.0 to 0.228.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.227.0...v0.228.0) Updates `istio.io/api` from 1.25.0 to 1.25.1 - [Commits](istio/api@1.25.0...1.25.1) Updates `istio.io/client-go` from 1.25.0 to 1.25.1 - [Commits](istio/client-go@1.25.0...1.25.1) --- updated-dependencies: - dependency-name: github.com/IBM/networking-go-sdk dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/credentials dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/civo/civogo dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/digitalocean/godo dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/oracle/oci-go-sdk/v65 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/projectcontour/contour dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/scaleway/scaleway-sdk-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/privatedns dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: go.etcd.io/etcd/client/v3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: istio.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: istio.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> chore: add se for nlb, alb in thailand region chore(code-cleanup): move logic away from main.go add tests (kubernetes-sigs#5222) * feat(code cleanup): remove from main.go Signed-off-by: ivan katliarchuk <[email protected]> * chore(code-cleanup): move logic from main.go add tests Signed-off-by: ivan katliarchuk <[email protected]> * chore(code-cleanup): move logic from main.go add tests Signed-off-by: ivan katliarchuk <[email protected]> * chore(code-cleanup): move logic from main.go add tests Signed-off-by: ivan katliarchuk <[email protected]> * chore(code-cleanup): move logic from main.go add tests Signed-off-by: ivan katliarchuk <[email protected]> * chore(code-cleanup): move logic away from main.go add tests Signed-off-by: ivan katliarchuk <[email protected]> * chore(code-cleanup): move logic away from main.go add tests Signed-off-by: ivan katliarchuk <[email protected]> * chore(code-cleanup): move logic away from main.go add tests Co-authored-by: Michel Loiseleur <[email protected]> * chore(code-cleanup): move logic away from main.go add tests Signed-off-by: ivan katliarchuk <[email protected]> * chore(code-cleanup): move logic away from main.go add tests Signed-off-by: ivan katliarchuk <[email protected]> --------- Signed-off-by: ivan katliarchuk <[email protected]> Co-authored-by: Michel Loiseleur <[email protected]> docs(proposal): externaldns api graduation to beta (kubernetes-sigs#5079) * docs(proposal): externaldns api graduation to beta Signed-off-by: ivan katliarchuk <[email protected]> * docs(proposal): externaldns api graduation to beta Signed-off-by: ivan katliarchuk <[email protected]> * docs(proposal): externaldns api graduation to beta Signed-off-by: ivan katliarchuk <[email protected]> * docs(proposal): externaldns api graduation to beta Signed-off-by: ivan katliarchuk <[email protected]> * docs(proposal): externaldns api graduation to beta Signed-off-by: ivan katliarchuk <[email protected]> * docs(proposal): externaldns api graduation to beta Signed-off-by: ivan katliarchuk <[email protected]> * docs(proposal): externaldns api graduation to beta Signed-off-by: ivan katliarchuk <[email protected]> * docs(proposal): externaldns api graduation to beta Signed-off-by: ivan katliarchuk <[email protected]> * docs(proposal): externaldns api graduation to beta Co-authored-by: Michel Loiseleur <[email protected]> * docs(proposal): externaldns api graduation to beta --------- Signed-off-by: ivan katliarchuk <[email protected]> Co-authored-by: Michel Loiseleur <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> fix(helm): added missing schema values (kubernetes-sigs#5228) * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> * fix(helm): added missing schema values Signed-off-by: ivan katliarchuk <[email protected]> --------- Signed-off-by: ivan katliarchuk <[email protected]> chore(ci): update linter to v2.0.2 feat(pihole): add optional support for v6 (kubernetes-sigs#5226) * Pi hole V6 impl * Code Review Part One * Fix Go Lint * Regenerate Flags file * Increase code coverage 1/2 * Increase code coverage 2/2 * Fix merge conflict => Provider init move from main.go to execute.go chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> fix(cloudflare): custom hostnames edge-cases causing duplicates syntax/style Use %q log fmt for cloudflare provider code move custom hostnames related submitChanges() implementation to a separate method submitCustomHostnameChanges(); extend truncated logging use maps for DNS records getRecordID() and custom hostnames getCustomHostname() for faster lookups types for records/custom hostnames maps tidy up using underlying maps for dns records and custom hostnames style/naming fix private names combine unnecessarily separated conditions feat(cloudflare): multiple custom hostnames support remove redunaant custom hostnames sort rename variables with ambiguous "endpoint" names Update cloudflare.md split long lines [attempt to] improve nested conditions readability for cloudflare tests failures scenarios add test for logging error when creating endpoint and ignoring too long record name (shouldn't happen) docs: update link to Anexia webhook provider chore(deps): bump the dev-dependencies group across 1 directory with 2 updates Bumps the dev-dependencies group with 2 updates in the / directory: [renovatebot/github-action](https://github.com/renovatebot/github-action) and [actions/setup-python](https://github.com/actions/setup-python). Updates `renovatebot/github-action` from 41.0.17 to 41.0.18 - [Release notes](https://github.com/renovatebot/github-action/releases) - [Changelog](https://github.com/renovatebot/github-action/blob/main/CHANGELOG.md) - [Commits](renovatebot/github-action@v41.0.17...v41.0.18) Updates `actions/setup-python` from 5.4.0 to 5.5.0 - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@4237552...8d9ed9a) --- updated-dependencies: - dependency-name: renovatebot/github-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> feat(source): optional exclusion of unschedulable nodes (kubernetes-sigs#5045) * feat(source/node): Make exclusion of unschedulable Nodes configurable This fixes a behavioral regression introduced in kubernetes-sigs#4761, where nodes that were previously added to DNS are removed when they are considered unschedulable, for example due to automated maintenance tasks. This change will introduce a new flag called `exclude-unschedulable`, which defaults to `true` in order to keep in line with the current behavior. However, it would also be reasonable to restore the initial behavior before * Allow testing for expected log entries in testNodeSourceEndpoints This commit adds the required logic to be able to test for the existence (and absence) of certain log messages in testNodeSourceEndpoints. As an example, this is implemented for the tests around excludeUnschedulable. A side effect of using LogsToBuffer is that tests can't run in parallel due to the log buffer being shared across all parallel test cases. As such, these specific tests are now executed one after another. * Ensure logging is only hooked for tests that require it * Document new exclude-unschedulable flag for nodes source chore(deps): bump the dev-dependencies group across 1 directory with 19 updates Bumps the dev-dependencies group with 14 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/Azure/azure-sdk-for-go/sdk/azcore](https://github.com/Azure/azure-sdk-for-go) | `1.17.1` | `1.18.0` | | [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) | `1.63.103` | `1.63.104` | | [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.29.12` | `1.29.13` | | [github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue](https://github.com/aws/aws-sdk-go-v2) | `1.18.8` | `1.18.9` | | [github.com/aws/aws-sdk-go-v2/service/route53](https://github.com/aws/aws-sdk-go-v2) | `1.50.0` | `1.51.0` | | [github.com/aws/aws-sdk-go-v2/service/servicediscovery](https://github.com/aws/aws-sdk-go-v2) | `1.35.1` | `1.35.2` | | [github.com/linode/linodego](https://github.com/linode/linodego) | `1.48.1` | `1.49.0` | | [github.com/miekg/dns](https://github.com/miekg/dns) | `1.1.64` | `1.1.65` | | [github.com/oracle/oci-go-sdk/v65](https://github.com/oracle/oci-go-sdk) | `65.88.0` | `65.88.1` | | [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.1134` | `1.0.1140` | | [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod](https://github.com/tencentcloud/tencentcloud-sdk-go) | `1.0.1134` | `1.0.1136` | | [golang.org/x/net](https://github.com/golang/net) | `0.38.0` | `0.39.0` | | [golang.org/x/oauth2](https://github.com/golang/oauth2) | `0.28.0` | `0.29.0` | | gopkg.in/ns1/ns1-go.v2 | `2.13.0` | `2.14.1` | Updates `github.com/Azure/azure-sdk-for-go/sdk/azcore` from 1.17.1 to 1.18.0 - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.17.1...sdk/azcore/v1.18.0) Updates `github.com/aliyun/alibaba-cloud-sdk-go` from 1.63.103 to 1.63.104 - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.103...v1.63.104) Updates `github.com/aws/aws-sdk-go-v2/config` from 1.29.12 to 1.29.13 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@config/v1.29.12...config/v1.29.13) Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.17.65 to 1.17.66 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@credentials/v1.17.65...credentials/v1.17.66) Updates `github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue` from 1.18.8 to 1.18.9 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/config/v1.18.9/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@config/v1.18.8...config/v1.18.9) Updates `github.com/aws/aws-sdk-go-v2/service/dynamodb` from 1.42.0 to 1.42.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.42.0...service/s3/v1.42.1) Updates `github.com/aws/aws-sdk-go-v2/service/route53` from 1.50.0 to 1.51.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.50.0...service/s3/v1.51.0) Updates `github.com/aws/aws-sdk-go-v2/service/servicediscovery` from 1.35.1 to 1.35.2 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/kms/v1.35.1...service/ecr/v1.35.2) Updates `github.com/aws/aws-sdk-go-v2/service/sts` from 1.33.17 to 1.33.18 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/sns/v1.33.17...service/sns/v1.33.18) Updates `github.com/linode/linodego` from 1.48.1 to 1.49.0 - [Release notes](https://github.com/linode/linodego/releases) - [Commits](linode/linodego@v1.48.1...v1.49.0) Updates `github.com/miekg/dns` from 1.1.64 to 1.1.65 - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.64...v1.1.65) Updates `github.com/oracle/oci-go-sdk/v65` from 65.88.0 to 65.88.1 - [Release notes](https://github.com/oracle/oci-go-sdk/releases) - [Changelog](https://github.com/oracle/oci-go-sdk/blob/master/CHANGELOG.md) - [Commits](oracle/oci-go-sdk@v65.88.0...v65.88.1) Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common` from 1.0.1134 to 1.0.1140 - [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.1134...v1.0.1140) Updates `github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod` from 1.0.1134 to 1.0.1136 - [Commits](TencentCloud/tencentcloud-sdk-go@v1.0.1134...v1.0.1136) Updates `golang.org/x/net` from 0.38.0 to 0.39.0 - [Commits](golang/net@v0.38.0...v0.39.0) Updates `golang.org/x/oauth2` from 0.28.0 to 0.29.0 - [Commits](golang/oauth2@v0.28.0...v0.29.0) Updates `golang.org/x/sync` from 0.12.0 to 0.13.0 - [Commits](golang/sync@v0.12.0...v0.13.0) Updates `golang.org/x/text` from 0.23.0 to 0.24.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.23.0...v0.24.0) Updates `gopkg.in/ns1/ns1-go.v2` from 2.13.0 to 2.14.1 --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azcore dependency-version: 1.18.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-version: 1.63.104 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-version: 1.29.13 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/credentials dependency-version: 1.17.66 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue dependency-version: 1.18.9 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/dynamodb dependency-version: 1.42.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/route53 dependency-version: 1.51.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/servicediscovery dependency-version: 1.35.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/sts dependency-version: 1.33.18 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/linode/linodego dependency-version: 1.49.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/miekg/dns dependency-version: 1.1.65 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/oracle/oci-go-sdk/v65 dependency-version: 65.88.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common dependency-version: 1.0.1140 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod dependency-version: 1.0.1136 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: golang.org/x/net dependency-version: 0.39.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: golang.org/x/oauth2 dependency-version: 0.29.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: golang.org/x/sync dependency-version: 0.13.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: golang.org/x/text dependency-version: 0.24.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: gopkg.in/ns1/ns1-go.v2 dependency-version: 2.14.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> chore(helm): add validation for prefix and suffix and capture regression (kubernetes-sigs#5250) * chore(helm): add valiation.tpl and capture regression Signed-off-by: ivan katliarchuk <[email protected]> * chore(helm): add valiation.tpl and capture regression Signed-off-by: ivan katliarchuk <[email protected]> * chore(helm): add validation.tpl and capture regression Co-authored-by: Michel Loiseleur <[email protected]> * chore(helm): add validation.tpl and capture regression Co-authored-by: Michel Loiseleur <[email protected]> * chore(helm): add validation.tpl and capture regression Signed-off-by: ivan katliarchuk <[email protected]> * chore(helm): add validation.tpl and capture regression Signed-off-by: ivan katliarchuk <[email protected]> * chore(helm): add validation for prefix and suffix and capture regression Signed-off-by: ivan katliarchuk <[email protected]> * chore(helm): add validation for prefix and suffix and capture regression Signed-off-by: ivan katliarchuk <[email protected]> * chore(helm): add validation for prefix and suffix and capture regression Signed-off-by: ivan katliarchuk <[email protected]> * chore(helm): add validation for prefix and suffix and capture regression Co-authored-by: Steve Hipwell <[email protected]> --------- Signed-off-by: ivan katliarchuk <[email protected]> Co-authored-by: Michel Loiseleur <[email protected]> Co-authored-by: Steve Hipwell <[email protected]> chore(ci): fix random data race failure on source/node test only consider accepted gateway routes if the condition generation matches the current one use route parentRef from spec instead of observedGeneration to select correct status conditions to evaluate update all route tests to have a valid spec.parentRef entry add missing lookup for TLSRoute update gatewayRoute to contain spec.parentRefs instead of extracting that directly from each route during the resolve stage update comment on gwRouteIsAccepted validate group and kind on the spec.parentRef. Move check into gwRouteHasParentRef remove unnecessary variable chore: Release Helm chart v1.16.1 Signed-off-by: Steve Hipwell <[email protected]> fix cloudflare regional hostnames Implements create & delete of regional hostnames for A, AAAA & CNAME records. Implements "external-dns.alpha.kubernetes.io/cloudflare-region-key" annotation. add tests & fixes for dataLocalizationRegionalHostnamesChanges() chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]> changes to goccy yaml Signed-off-by: Raffaele Di Fazio <[email protected]> use json to unmarshal json Signed-off-by: Raffaele Di Fazio <[email protected]> chore(dependencies): update toools versions (kubernetes-sigs#5252) * chore(dependencies): update toools versions Signed-off-by: ivan katliarchuk <[email protected]> * chore(dependencies): update toools versions Signed-off-by: ivan katliarchuk <[email protected]> * chore(dependencies): update toools versions Signed-off-by: ivan katliarchuk <[email protected]> * chore(dependencies): update toools versions Signed-off-by: ivan katliarchuk <[email protected]> * chore(dependencies): update toools versions Signed-off-by: ivan katliarchuk <[email protected]> * chore(dependencies): update toools versions Signed-off-by: ivan katliarchuk <[email protected]> * chore(dependencies): update toools versions Signed-off-by: ivan katliarchuk <[email protected]> --------- Signed-off-by: ivan katliarchuk <[email protected]> chore(source): code cleanup Signed-off-by: ivan katliarchuk <[email protected]>

…o v0.16.1 (#667) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry.k8s.io/external-dns/external-dns](https://github.com/kubernetes-sigs/external-dns) | minor | `v0.15.1` -> `v0.16.1` | --- ### Release Notes <details> <summary>kubernetes-sigs/external-dns (registry.k8s.io/external-dns/external-dns)</summary> ### [`v0.16.1`](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.16.1) [Compare Source](kubernetes-sigs/external-dns@v0.16.0...v0.16.1) This release fixes the breaking change introduced in v0.16.0 for Cloudflare. :warning: New features on Cloudflare, custom and regional hostnames have some known issues, see [#5175](kubernetes-sigs/external-dns#5175) and [#5183](kubernetes-sigs/external-dns#5183) :warning: OpenStack designate in-tree provider will be removed in the next version. There is now a [webhook provider](https://github.com/inovex/external-dns-openstack-webhook). :information_source: With v0.16.0, a new option on TXT Registry is available to use only new format ([#4946](kubernetes-sigs/external-dns#4946)). Previous format will be removed in the next release ([#5172](kubernetes-sigs/external-dns#5172)). #### 🐛 Bug fixes - fix(cloudflare): optional custom hostnames by [@mrozentsvayg](https://github.com/mrozentsvayg) in kubernetes-sigs/external-dns#5146 - fix(source): pass GatewayName to config by [@buroa](https://github.com/buroa) in kubernetes-sigs/external-dns#5169 - fix(cloudflare): infinite loop with more than 50 custom hostnames by [@mrozentsvayg](https://github.com/mrozentsvayg) in kubernetes-sigs/external-dns#5181 #### 📦 Others - chore: update OWNERS with required config file by [@mloiseleur](https://github.com/mloiseleur) in kubernetes-sigs/external-dns#5164 **Full Changelog**: kubernetes-sigs/external-dns@v0.16.0...v0.16.1 ### [`v0.16.0`](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.16.0) [Compare Source](kubernetes-sigs/external-dns@v0.15.1...v0.16.0) #### 💥 Breaking Changes There is a [breaking change on Cloudflare](kubernetes-sigs/external-dns#5166) with this release. It requires Cloudflare for Saas. #### 🚀 Features - feat: add dreamhost webook provider to readme ([#5015](kubernetes-sigs/external-dns#5015)) [@asymingt](https://github.com/asymingt) - feat: Add F5 TransportServer source ([#4944](kubernetes-sigs/external-dns#4944)) [@visokoo](https://github.com/visokoo) - feat(chart): allow to run tpl on `ServiceAccount` annotations ([#4958](kubernetes-sigs/external-dns#4958)) ([#4958](kubernetes-sigs/external-dns#4958)) [@fcrespofastly](https://github.com/fcrespofastly) - feat(cloudflare): custom hostname and fix apex ([#5087](kubernetes-sigs/external-dns#5087)) [@mrozentsvayg](https://github.com/mrozentsvayg) - feat(deps): added renovate config for custom regexes ([#4978](kubernetes-sigs/external-dns#4978)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - feat: don't discard klog logs at the highest log levels (debug and trace) ([#4961](kubernetes-sigs/external-dns#4961)) [@dmarkhas](https://github.com/dmarkhas) - feat(pdns): add validation for MX and SRV records ([#4871](kubernetes-sigs/external-dns#4871)) [@julillae](https://github.com/julillae) - feat(rfc2136): support multiple hosts ([#4653](kubernetes-sigs/external-dns#4653)) [@Jeremy-Boyle](https://github.com/Jeremy-Boyle) - feat(service): listen to endpoint changes ([#5085](kubernetes-sigs/external-dns#5085)) [@dmarkhas](https://github.com/dmarkhas) - feat(source): allow to register all pods and their associated PTR record ([#4782](kubernetes-sigs/external-dns#4782)) [@foyerunix](https://github.com/foyerunix) - feat(txt-registry): add option to use only new format ([#4946](kubernetes-sigs/external-dns#4946)) [@malpou](https://github.com/malpou) #### 🐛 Bug fixes - fix(aes-encryption): support plain txt and url safe base64 strings ([#4980](kubernetes-sigs/external-dns#4980)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - fix(aws-provider): ListTagsForResource incorrect zone-id handling ([#5029](kubernetes-sigs/external-dns#5029)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - fix(chart): non-string types on svcaccount annotations ([#5067](kubernetes-sigs/external-dns#5067)) [@hjoshi123](https://github.com/hjoshi123) - fix(chart): regression with affinity.nodeAffinity getting ignored ([#5046](kubernetes-sigs/external-dns#5046)) [@mkhpalm](https://github.com/mkhpalm) - fix(chart): update rbac for F5 transportserver source ([#5066](kubernetes-sigs/external-dns#5066)) ([#5066](kubernetes-sigs/external-dns#5066)) [@visokoo](https://github.com/visokoo) - fix(cloudflare): add more descriptive log message ([#5047](kubernetes-sigs/external-dns#5047)) [@AndrewCharlesHay](https://github.com/AndrewCharlesHay) - fix(cloudflare): use softerror on internal server error with api ([#4931](kubernetes-sigs/external-dns#4931)) [@vishuvenu](https://github.com/vishuvenu) - fix(dedup): records with different type are not duplicates ([#4889](kubernetes-sigs/external-dns#4889)) [@jtszalay](https://github.com/jtszalay) - fix(docs): aws tutorial broken internal markdown links ([#5036](kubernetes-sigs/external-dns#5036)) [@strophy](https://github.com/strophy) - fix: do not merge CNAME with multiple targets ([#4856](kubernetes-sigs/external-dns#4856)) [@dtuck9](https://github.com/dtuck9) - fix(f5-virtualserver): skip endpoint creation when VirtualServer is not ready ([#4996](kubernetes-sigs/external-dns#4996)) [@mikejoh](https://github.com/mikejoh) - fix(godaddy): Handle missing Retry-After header gracefully ([#4866](kubernetes-sigs/external-dns#4866)) [@alexstojda](https://github.com/alexstojda) - fix(oci): records with multiple IP addresses ([#4993](kubernetes-sigs/external-dns#4993)) [@jrosinsk](https://github.com/jrosinsk) - fix(ovh): cache refresh and duplicates processing ([#4932](kubernetes-sigs/external-dns#4932)) [@nmaupu](https://github.com/nmaupu) - fix(registry): handle empty targets in TXT records logging an error ([#5149](kubernetes-sigs/external-dns#5149)) [@saikatharryc](https://github.com/saikatharryc) - fix(source): allow ipv4-mapped ipv6 addresses ([#4943](kubernetes-sigs/external-dns#4943)) [@buroa](https://github.com/buroa) - fix(source): debug log on gateway target detection ([#5096](kubernetes-sigs/external-dns#5096)) [@drcapulet](https://github.com/drcapulet) - Fix spelling in webhook OpenAPI spec ([#5038](kubernetes-sigs/external-dns#5038)) [@claycooper](https://github.com/claycooper) - fix: use informer for istio gateways ([#4522](kubernetes-sigs/external-dns#4522)) [@woehrl01](https://github.com/woehrl01) #### 📝 Documentation - docs: add deprecation policy ([#5053](kubernetes-sigs/external-dns#5053)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs: add staging images to release process ([#5050](kubernetes-sigs/external-dns#5050)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs: fix typo on aws tutorial ([#5070](kubernetes-sigs/external-dns#5070)) [@Ileriayo](https://github.com/Ileriayo) - docs: fix typos in tutorials ([#4969](kubernetes-sigs/external-dns#4969)) [@mloiseleur](https://github.com/mloiseleur) - docs(Microsoft DNS): improve instructions ([#4893](kubernetes-sigs/external-dns#4893)) [@TomyLobo](https://github.com/TomyLobo) - docs(proposal): standartise date format ([#5128](kubernetes-sigs/external-dns#5128)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs(proposal): update template with statuses ([#5098](kubernetes-sigs/external-dns#5098)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - docs(provider): add ClouDNS to README ([#5065](kubernetes-sigs/external-dns#5065)) [@rwunderer](https://github.com/rwunderer) - docs(README): fix link to dev guide ([#5116](kubernetes-sigs/external-dns#5116)) [@masterkain](https://github.com/masterkain) - docs(registry): fix managed-record-type argument ([#5102](kubernetes-sigs/external-dns#5102)) [@splitice](https://github.com/splitice) - docs: update and refactor contribution part ([#5073](kubernetes-sigs/external-dns#5073)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - ci(docs): add markdown linters and editorconfig ([#5055](kubernetes-sigs/external-dns#5055)) [@mloiseleur](https://github.com/mloiseleur) - Improve sources' docs to mention '--managed-record-types' ([#4882](kubernetes-sigs/external-dns#4882)) [@juan-vg](https://github.com/juan-vg) #### 📦 Others - add: auto label source and providers ([#5158](kubernetes-sigs/external-dns#5158)) [@szuecs](https://github.com/szuecs) - Add OpenStack Designate webook provider to readme ([#5115](kubernetes-sigs/external-dns#5115)) [@frittentheke](https://github.com/frittentheke) - chore(ci): fix and sort changelog ([#4979](kubernetes-sigs/external-dns#4979)) [@mloiseleur](https://github.com/mloiseleur) dependabot - chore(ci): fix failing test, upgrade to go 1.23.5 and linter to v1.63 ([#5013](kubernetes-sigs/external-dns#5013)) [@mloiseleur](https://github.com/mloiseleur) - chore(ci): remove too slow test ([#5014](kubernetes-sigs/external-dns#5014)) [@mloiseleur](https://github.com/mloiseleur) - chore(deps): bump actions/setup-python from 5.3.0 to 5.4.0 in the dev-dependencies group ([#5041](kubernetes-sigs/external-dns#5041)) [@dependabot](https://github.com/dependabot) - chore(deps): bump azure/setup-helm from 4.2.0 to 4.3.0 in the dev-dependencies group ([#5108](kubernetes-sigs/external-dns#5108)) [@dependabot](https://github.com/dependabot) - chore(deps): bump helm/kind-action from 1.10.0 to 1.11.0 in the dev-dependencies group ([#4956](kubernetes-sigs/external-dns#4956)) [@dependabot](https://github.com/dependabot) - chore(deps): bump helm/kind-action from 1.11.0 to 1.12.0 in the dev-dependencies group ([#4972](kubernetes-sigs/external-dns#4972)) [@dependabot](https://github.com/dependabot) - chore(deps): bump nosborn/github-action-markdown-cli from 3.3.0 to 3.4.0 in the dev-dependencies group ([#5083](kubernetes-sigs/external-dns#5083)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 14 updates ([#4976](kubernetes-sigs/external-dns#4976)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 18 updates ([#5040](kubernetes-sigs/external-dns#5040)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 20 updates ([#4999](kubernetes-sigs/external-dns#4999)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 21 updates ([#5089](kubernetes-sigs/external-dns#5089)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 22 updates ([#5062](kubernetes-sigs/external-dns#5062)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 23 updates ([#5145](kubernetes-sigs/external-dns#5145)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 25 updates ([#5023](kubernetes-sigs/external-dns#5023)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 5 updates ([#4987](kubernetes-sigs/external-dns#4987)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group across 1 directory with 7 updates ([#5125](kubernetes-sigs/external-dns#5125)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 20 updates ([#5109](kubernetes-sigs/external-dns#5109)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 2 updates ([#5022](kubernetes-sigs/external-dns#5022)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 3 updates ([#5112](kubernetes-sigs/external-dns#5112)) [@dependabot](https://github.com/dependabot) - chore(deps): bump the dev-dependencies group with 4 updates ([#4988](kubernetes-sigs/external-dns#4988)) [@dependabot](https://github.com/dependabot) - chore(docs): docs/flags.md generation ([#4983](kubernetes-sigs/external-dns#4983)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(filter-tags): pre-process filter tags ([#5063](kubernetes-sigs/external-dns#5063)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(makefile): add helper and document targets ([#5093](kubernetes-sigs/external-dns#5093)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(makefile): simplify coverage script ([#5105](kubernetes-sigs/external-dns#5105)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(provider-aws): improve canonicalHostedZone handling ([#5031](kubernetes-sigs/external-dns#5031)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore(release): publish chart v1.15.2 ([#5094](kubernetes-sigs/external-dns#5094)) [@stevehipwell](https://github.com/stevehipwell) - chore: update maintainers/reviewers ([#5020](kubernetes-sigs/external-dns#5020)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - chore: upgrade ExternalDNS to go 1.24 ([#5106](kubernetes-sigs/external-dns#5106)) [@mloiseleur](https://github.com/mloiseleur) - kustomize-v0.15.1 ([#4966](kubernetes-sigs/external-dns#4966)) [@Raffo](https://github.com/Raffo) - Release Helm chart for `v0.15.1` ([#5028](kubernetes-sigs/external-dns#5028)) [@stevehipwell](https://github.com/stevehipwell) - replace all versions to v0.15.1 ([#4973](kubernetes-sigs/external-dns#4973)) [@Raffo](https://github.com/Raffo) - test(cloudflare): add scenarios on submitChanges ([#5054](kubernetes-sigs/external-dns#5054)) [@AndrewCharlesHay](https://github.com/AndrewCharlesHay) - test(domain-filter): simple filters on domain exclusion ([#5064](kubernetes-sigs/external-dns#5064)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) - test(provider): tags filter coverage and benchmark ([#5060](kubernetes-sigs/external-dns#5060)) [@ivankatliarchuk](https://github.com/ivankatliarchuk) #### New Contributors - [@juan-vg](https://github.com/juan-vg) made their first contribution in kubernetes-sigs/external-dns#4882 - [@dmarkhas](https://github.com/dmarkhas) made their first contribution in kubernetes-sigs/external-dns#4961 - [@buroa](https://github.com/buroa) made their first contribution in kubernetes-sigs/external-dns#4943 - [@fcrespofastly](https://github.com/fcrespofastly) made their first contribution in kubernetes-sigs/external-dns#4958 - [@nmaupu](https://github.com/nmaupu) made their first contribution in kubernetes-sigs/external-dns#4932 - [@dtuck9](https://github.com/dtuck9) made their first contribution in kubernetes-sigs/external-dns#4856 - [@asymingt](https://github.com/asymingt) made their first contribution in kubernetes-sigs/external-dns#5015 - [@alexstojda](https://github.com/alexstojda) made their first contribution in kubernetes-sigs/external-dns#4866 - [@visokoo](https://github.com/visokoo) made their first contribution in kubernetes-sigs/external-dns#4944 - [@vishuvenu](https://github.com/vishuvenu) made their first contribution in kubernetes-sigs/external-dns#4931 - [@TomyLobo](https://github.com/TomyLobo) made their first contribution in kubernetes-sigs/external-dns#4893 - [@strophy](https://github.com/strophy) made their first contribution in kubernetes-sigs/external-dns#5036 - [@malpou](https://github.com/malpou) made their first contribution in kubernetes-sigs/external-dns#4946 - [@foyerunix](https://github.com/foyerunix) made their first contribution in kubernetes-sigs/external-dns#4782 - [@rwunderer](https://github.com/rwunderer) made their first contribution in kubernetes-sigs/external-dns#5065 - [@Ileriayo](https://github.com/Ileriayo) made their first contribution in kubernetes-sigs/external-dns#5070 - [@hjoshi123](https://github.com/hjoshi123) made their first contribution in kubernetes-sigs/external-dns#5067 - [@mkhpalm](https://github.com/mkhpalm) made their first contribution in kubernetes-sigs/external-dns#5046 - [@woehrl01](https://github.com/woehrl01) made their first contribution in kubernetes-sigs/external-dns#4522 - [@jtszalay](https://github.com/jtszalay) made their first contribution in kubernetes-sigs/external-dns#4889 - [@splitice](https://github.com/splitice) made their first contribution in kubernetes-sigs/external-dns#5102 - [@drcapulet](https://github.com/drcapulet) made their first contribution in kubernetes-sigs/external-dns#5096 - [@mrozentsvayg](https://github.com/mrozentsvayg) made their first contribution in kubernetes-sigs/external-dns#5087 - [@frittentheke](https://github.com/frittentheke) made their first contribution in kubernetes-sigs/external-dns#5115 - [@masterkain](https://github.com/masterkain) made their first contribution in kubernetes-sigs/external-dns#5116 - [@renanqts](https://github.com/renanqts) made their first contribution in kubernetes-sigs/external-dns#5132 - [@rlees85](https://github.com/rlees85) made their first contribution in kubernetes-sigs/external-dns#5111 - [@stefaneg](https://github.com/stefaneg) made their first contribution in kubernetes-sigs/external-dns#5135 - [@saikatharryc](https://github.com/saikatharryc) made their first contribution in kubernetes-sigs/external-dns#5149 **Full Changelog**: kubernetes-sigs/external-dns@v0.15.1...v0.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://codeberg.org/JesusMtnez/homelab/pulls/667 Co-authored-by: JesusMtnez-bot <[email protected]> Co-committed-by: JesusMtnez-bot <[email protected]>

bugfix - do not reset the resultInfo var, causing infinite loop when …

5dfa977

…number of custom hostnames more than 50

k8s-ci-robot requested review from ivankatliarchuk and mloiseleur March 14, 2025 02:27

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2025

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2025

k8s-ci-robot changed the title ~~bugfix - do not reset the resultInfo var, causing infinite loop when …~~ fix(cloudflare): infinite loop with more than 50 hostnames Mar 14, 2025

k8s-ci-robot changed the title ~~fix(cloudflare): infinite loop with more than 50 hostnames~~ fix(cloudflare): infinite loop with more than 50 custom hostnames Mar 14, 2025

support paging for custom hostnames tests; update doc

059fdfa

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2025

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 14, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2025

ivankatliarchuk approved these changes Mar 14, 2025

View reviewed changes

k8s-ci-robot assigned ivankatliarchuk Mar 14, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025

mloiseleur approved these changes Mar 14, 2025

View reviewed changes

k8s-ci-robot assigned mloiseleur Mar 14, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025

k8s-ci-robot merged commit 017f768 into kubernetes-sigs:master Mar 14, 2025
16 checks passed

jakjakmetmet mentioned this pull request Nov 3, 2025

Cloudflare DNS records are updated in an infinite loop #5934

Open

fix(cloudflare): infinite loop with more than 50 custom hostnames #5181

fix(cloudflare): infinite loop with more than 50 custom hostnames #5181

Uh oh!

Conversation

mrozentsvayg commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 14, 2025

Uh oh!

mrozentsvayg commented Mar 14, 2025

Uh oh!

mloiseleur commented Mar 14, 2025

Uh oh!

mloiseleur commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mloiseleur commented Mar 14, 2025

Uh oh!

mloiseleur commented Mar 14, 2025

Uh oh!

ivankatliarchuk commented Mar 14, 2025

Uh oh!

mrozentsvayg commented Mar 14, 2025

Uh oh!

mrozentsvayg commented Mar 14, 2025

Uh oh!

ivankatliarchuk commented Mar 14, 2025

Uh oh!

ivankatliarchuk commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrozentsvayg commented Mar 14, 2025

Uh oh!

ivankatliarchuk commented Mar 14, 2025

Uh oh!

ivankatliarchuk commented Mar 14, 2025

Uh oh!

ivankatliarchuk commented Mar 14, 2025

Uh oh!

mrozentsvayg commented Mar 14, 2025

Uh oh!

ivankatliarchuk left a comment

Choose a reason for hiding this comment

Uh oh!

mloiseleur left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Mar 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mrozentsvayg commented Mar 14, 2025 •

edited

Loading

mloiseleur commented Mar 14, 2025 •

edited

Loading

ivankatliarchuk commented Mar 14, 2025 •

edited

Loading