-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(leader-election): leader election with multiple replicas support #5033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(leader-election): leader election with multiple replicas support #5033
Conversation
Signed-off-by: ivan katliarchuk <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
/retest-required |
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
…er changed Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/close not-planned |
First step to resolve #2430
Description
Proposal: #5051
Reason to close: discussion with maintainers/owners
A naive implementation for a leader election, based on official example. Could split this pull request to ease review
The proposal is to release
leader election
functionality and iterate/add improvements based on feedback. Flag had a suffix-experimental
to make sure it 100% clear that logic or implementation may change at some point. Would be nice to collect feedback from community and iterate.For leader election to be fully functional-opearational the number of bugs/currently open issues may need to be resolved as well. But this this not sound like a blocker.
kubernetes-sigs leader-election configured for
kuberntes org leader-elections configured for
In case we think that external-dns do not require HA setup with leader election or library is not fit for purpose. Same leader-election library used in (implementation sometimes differ). Most of this services have always enabled leader election funtionality
Checklist
curl localhost:7979/metrics
OKcurl localhost:7979/healthz
OKsome checks

running leader election (leader identified)
standby replica

leader identify changed

lease updated or leader change