-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple provider specific annotations of same type #4734
base: master
Are you sure you want to change the base?
Allow multiple provider specific annotations of same type #4734
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @roehrijn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Thanks. It looks good, implementation is light and it's documented 👍 |
Description
External DNS already supports exposing a single K8s service behind multiple hostnames by using the
external-dns.alpha.kubernetes.io/hostname
annotation with a comma-seperated list of hostnames in its value. One would do this for example for making a service availible with a technical, static hostname and a DNS load-balancer, like Route53 can act as, at the same time.However, when defining additonal annotations on the service, e.g.
external-dns.alpha.kubernetes.io/aws-weight
this always applies to all the hostnames of the service. This makes it impossible to define different weights for different hostnames on the same service. At the same time it is not possible that an annotation only applies to a single one and not all the hostnames of a service.This PR implements a solution to make exactly the described configuration possible by introducing a kind of "string map" notation in the annotations' values.
For example:
would define the two hostname
my.foo.app
andmy.foo.internal
, whereas a load balancing weight is only set formy.foo.app
.Checklist
Jan Roehrich [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum