-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix args for helm webhook deployment #4196
fix args for helm webhook deployment #4196
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @ArtificialQualia! |
Hi @ArtificialQualia. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ArtificialQualia could you add a changelog entry? |
@stevehipwell Added a changelog entry. I'm still hunting down who is the proper CLA Manager for my org, but I should hopefully have their approval soon. Edit: Wasn't able to find the CLA Manager by the end of the business day, CLA signoff will probably have to wait until Monday at the earliest. |
@ArtificialQualia if you can't find someone for the CLA I'm happy to make this change in a new PR so it's released? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@stevehipwell sorry, I've been working the past three days to find a CLA Manager for this with no success so far. I see that there is already another PR with this fix in, so if you want to merge that one instead that's fine as I'm having trouble getting a response on my side. |
/close |
@stevehipwell: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
This fixes what appears to be a typo in the helm release which is preventing the ability to provide
args
to the webhook container.Fixes #4195
Checklist