introduce template error on purpose to test PR

[knelasevero]

I am not adding WIP/draft since we want tests to run and check how prow behaves with this thing

[k8s-ci-robot]

Hi @knelasevero. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knelasevero]

@ingvagabund how would we properly test this (as we discussed, checking if prow would avoid merging also with gh-actions failing) without the risk of the actual merge?

[damemi]

/hold
/ok-to-test

fyi I think WIP will still run tests (it just adds the hold label), but draft PRs don't run tests

[knelasevero]

fyi I think WIP will still run tests (it just adds the hold label), but draft PRs don't run tests

Thanks!

@ingvagabund I don't think we can follow what you described in #895 (comment)

If we don't remove the test from test-infra, and try to introduce an error on purpose, it will fail there anyways... and then we can't test if prow will consider gh-actions steps. Also we have a helm lint check on pull-descheduler-verify-master step 🤔

[knelasevero]

I have asked a clarification question on slack on #prow channel: https://kubernetes.slack.com/archives/CDECRSC5U/p1660078225162069

[ingvagabund]

If we don't remove the test from test-infra, and try to introduce an error on purpose, it will fail there anyways... and then we can't test if prow will consider gh-actions steps. Also we have a helm lint check on pull-descheduler-verify-master step

Updating the Makefile and temporarily skipping both the test-helm script and the lint-chart might help. We can always quickly revert this PR if it merges by accident.

[knelasevero]

Updating the Makefile and temporarily skipping both the test-helm script and the lint-chart might help. We can always quickly revert this PR if it merges by accident.

Nice suggestion. I think we can test already. Prow folks already told me prow would hold(see conversation), but does not hurt to test :D

[knelasevero]

based on

We can always quickly revert this PR if it merges by accident.

I am going to

/unhold

[ingvagabund]

/approve
/lgtm
Fingers crossed

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knelasevero]

Pending — Not mergeable. Job lint-and-test has not succeeded.

Victory 🎉

[knelasevero]

Closing since this is validated