-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add helm ct install. #904
add helm ct install. #904
Conversation
Hi @knelasevero. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It wont show meaningful info in this CI run on the ct install step since https://github.com/kubernetes-sigs/descheduler/pull/895/files#r934574223 was removed and we don't have chart changes. |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
# Need a multi node cluster so descheduler runs until evictions | ||
- name: Create multi node Kind cluster | ||
run: | | ||
kind create cluster --name kind --config ./hack/kind_config.yaml --wait 2m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@knelasevero what step install the kind
cli? and how can I control the verison?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if kind comes pre-baked in this gh-actions image or if it is installed by one of the previous actions 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I'm stuck on this, trying to bump kind to 0.15.0
First step, see #895 (comment)
Ater this PR is merged we can check it prow considers gh-actions when deciding to merge. After that we can go forward with the other changes from #895