bring removeduplicates to plugin

[JaneLiuL]

No description provided.

[knelasevero]

I think the deletiion of duplicates.go and duplicates_test.go are missing. With them moved to the framework better to delete from pkg/descheduler/strategies/

[a7i]

/ok-to-test

[JaneLiuL]

/cc @ingvagabund

[ingvagabund]

Thank You @JaneLiuL. I have found only few nits. Also as mentioned by @knelasevero it would be great to remove both
https://github.com/kubernetes-sigs/descheduler/blob/master/pkg/descheduler/strategies/duplicates.go and https://github.com/kubernetes-sigs/descheduler/blob/master/pkg/descheduler/strategies/duplicates_test.go in the same commit. So we can see the difference of both files and compare it with the new plugin files.

[JaneLiuL]

/retest

[JaneLiuL]

/assign @ingvagabund

[ingvagabund]

@JaneLiuL few more nits which are more of a cosmetic nature. I will leave the lgtm part for @a7i wrt. #892 (comment) comment.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JaneLiuL]

thanks @ingvagabund may i update at next pr? i will bring the toomayrestarts plugin tonight after this pr merge.

[ingvagabund]

@JaneLiuL I apologies, I missed your comment. #899 merged. Please feel free to ping me after the PR is rebased.

[JaneLiuL]

@ingvagabund would you help to have a look for this pr? :)

[ingvagabund]

ValidateRemoveDuplicatesArgs built on top of #899

/lgtm

[ingvagabund]

@JaneLiuL Thank You for your patience