Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chart path can't be relative #871

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

knelasevero
Copy link
Contributor

@knelasevero knelasevero commented Jul 4, 2022

For context:

There are a few other things worth discussing here:

  • Chart testing is complaining about using 'Kubernetes SIG Scheduling' as the maintainer of the chart. It expects a valid github/gitlab/something user. @damemi @ingvagabund Who should I put there? I can also put my name there if you folks think it is appropriate, now that I am making changes here.

  • I still need to add chart-testing installation checking. Will do that after linting is green.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @knelasevero. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 4, 2022
@k8s-ci-robot k8s-ci-robot requested review from damemi and JaneLiuL July 4, 2022 16:25
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 4, 2022
@knelasevero knelasevero changed the title fix: chart path can´t be relative fix: chart path can't be relative Jul 4, 2022
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 6, 2022
@damemi
Copy link
Contributor

damemi commented Jul 6, 2022

Thanks for the work @knelasevero

Chart testing is complaining about using 'Kubernetes SIG Scheduling' as the maintainer of the chart. It expects a valid github/gitlab/something user.

That's annoying. It would really be ideal if we can keep the SIG list as the maintainer to reduce the number of places we need to coordinate admins. Is there any way we can skip this check?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2022
@knelasevero
Copy link
Contributor Author

That's annoying. It would really be ideal if we can keep the SIG list as the maintainer to reduce the number of places we need to coordinate admins. Is there any way we can skip this check?

It seems --validate-maintainers=false did the trick :)

@a7i
Copy link
Contributor

a7i commented Jul 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2022
@damemi
Copy link
Contributor

damemi commented Jul 7, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8072a8c into kubernetes-sigs:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants