-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: chart path can't be relative #871
fix: chart path can't be relative #871
Conversation
Hi @knelasevero. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Thanks for the work @knelasevero
That's annoying. It would really be ideal if we can keep the SIG list as the maintainer to reduce the number of places we need to coordinate admins. Is there any way we can skip this check? |
It seems --validate-maintainers=false did the trick :) |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For context:
I created a PR to check if the CI would fail with a broken template:
Triggering chart CI to see if it fails #870
It didn't:
https://github.com/kubernetes-sigs/descheduler/pull/870/checks
Turns out the culprit was just the ./charts path at the config file in .github/ci/ct.yaml, so it was ignoring and not checking the chart
There are a few other things worth discussing here:
Chart testing is complaining about using 'Kubernetes SIG Scheduling' as the maintainer of the chart. It expects a valid github/gitlab/something user. @damemi @ingvagabund Who should I put there? I can also put my name there if you folks think it is appropriate, now that I am making changes here.
I still need to add chart-testing installation checking. Will do that after linting is green.