Skip to content

Enable ARM32v7 Container Image Builds#521

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
KohlsTechnology:armv7
Mar 10, 2021
Merged

Enable ARM32v7 Container Image Builds#521
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
KohlsTechnology:armv7

Conversation

@seanmalloy
Copy link
Member

Add ARM32v7 in addition to the currently supported architectures. This
will allow running descheduler on Raspberry Pi v3 devices.

Fixes #475

Add ARM32v7 in addition to the currently supported architectures. This
will allow running descheduler on Raspberry Pi v3 devices.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2021
@seanmalloy
Copy link
Member Author

/kind feature
/hold

This should work, but it doesn't. The docker manifest cannot be pushed. I think it's close, but not quite close enough.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 9, 2021
@seanmalloy
Copy link
Member Author

Looks like the docker version on my work laptop is too old to get the ARMv7 docker manifest to work.

Using a newer version of docker works correctly:
image

Copy link
Member

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@seanmalloy
Copy link
Member Author

Just need to test that I can pull the images from my test registry and update the end user docs.

@seanmalloy
Copy link
Member Author

I confirmed that the AMD64 image works. I have not way to test the ARM64 or ARMv7 images. I'll add the end user docs for the ARMv7 image to the end user guide closer to the v0.21.0 release.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2021
@seanmalloy
Copy link
Member Author

/cc @ingvagabund @lixiang233

@k8s-ci-robot k8s-ci-robot requested a review from lixiang233 March 9, 2021 15:51
@seanmalloy
Copy link
Member Author

FYI @cerebrate this enables the ARM32v7 images that you requested.

Copy link
Contributor

@lixiang233 lixiang233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0a11b5a into kubernetes-sigs:master Mar 10, 2021
@seanmalloy seanmalloy deleted the armv7 branch March 10, 2021 03:19
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Enable ARM32v7 Container Image Builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ARM (not ARM64) image support

4 participants