Move Inactive Maintainers to Emeritus Status

[seanmalloy]

For roughly the past year damemi has been the only active approver for
the descheduler. Therefore move the inactive approvers to emeritus
status. This will help clarify to contributors who should be assigned to
pull requests.

[seanmalloy]

I did not move @aveshagarwal to emeritus status because I think it is wise to have at least 2 approvers. But maybe @ingvagabund should be added as an approver?

/assign @damemi @ravisantoshgudimetla @k82cn
/cc @ingvagabund

[ingvagabund]

I still prefer to have approvers across different companies so we don't monopolize. Though, having two approvers will allow to distribute the responsibility so @damemi does not have to carry all the burden. Unless there are volunteers, I can take it.

[seanmalloy]

I still prefer to have approvers across different companies so we don't monopolize. Though, having two approvers will allow to distribute the responsibility so @damemi does not have to carry all the burden. Unless there are volunteers, I can take it.

I'm willing to volunteer to be an approver. Although I'm not confident that I meet the criteria to be an approver.

[damemi]

Ravi and Klaus's contributions to the descheduler are remarkable, and I think a move to emeritus status is a great way to recognize that work. It also makes it clearer to new contributors (and ci-bot) as to who may actively review their PRs, and cuts down on notification spam for them 🙂 If they are okay with this move, then it's fine with me.

Though, I think it would be best to add new approvers before removing any. Jan and Sean, I think either (or both) of you would be excellent additions. I do understand Jan's point about company diversity, however I would like our priority to be having the most active and knowledgeable contributors as approvers, to which I think you both fit the bill.

[seanmalloy]

I made some updates.

I'm proposing moving @ravisantoshgudimetla @k82cn and @aveshagarwal to emeritus status. I've added myself and @ingvagabund as new approvers.

[ingvagabund]

Worth updating https://github.com/kubernetes-sigs/descheduler/blob/master/Dockerfile#L24

[ravisantoshgudimetla]

Thank you for bringing this up @seanmalloy

I agree with @damemi's assessment both @seanmalloy and @ingvagabund deserve to become approvers and +1 to making me an emeritus approver.

[seanmalloy]

Worth updating https://github.com/kubernetes-sigs/descheduler/blob/master/Dockerfile#L24

Fixed in commit 5f4dfbc

[seanmalloy]

@aveshagarwal and @k82cn any concerns with this proposed change?

[aveshagarwal]

@aveshagarwal and @k82cn any concerns with this proposed change?

No concern. Fine with me.

[seanmalloy]

@k82cn I believe you are the last person we need sign off from.

/assign @k82cn

[seanmalloy]

@k82cn I believe you are the last person we need sign off from.

/assign @k82cn

@k82cn we are planning to merge this PR on Monday March 22nd if we do not here back from you. Thanks!

[k82cn]

/lgtm

[damemi]

/approve
@aveshagarwal @ravisantoshgudimetla @k82cn @seanmalloy @ingvagabund thank you everyone for all of your hard work and dedication to this project 🙂

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damemi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment