Deprecate node-selector, max-pods-to-evict-per-node and evict-local-storage-pods flags and promote then to policy v1alpha1 fields#380
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Aug 21, 2020
Conversation
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/M
ingvagabund
force-pushed
the
move-some-flags-under-descheduler-polic
branch
from
41e7a2e to
5f64dc0
Compare
ingvagabund
force-pushed
the
move-some-flags-under-descheduler-polic
branch
2 times, most recently
from
4ad4d63 to
cc49e2e
Compare
damemi
approved these changes
Aug 20, 2020
Member
damemi
left a comment
damemi
left a comment
There was a problem hiding this comment.
/approve
think this looks good to me. pretty simple change and the flags are still supported though clearly marked as deprecated 👍
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
|
@ingvagabund please update the output from |
…torage-pods flags and promote then to policy v1alpha1 fields
ingvagabund
force-pushed
the
move-some-flags-under-descheduler-polic
branch
from
cc49e2e to
89541f7
Compare
k8s-ci-robot
added
size/L
Contributor
Author
|
@seanmalloy |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
@ingvagabund I think you can remove the hold when you are ready for merge. Thanks! |
Contributor
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Closed
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
…gs-under-descheduler-polic Deprecate node-selector, max-pods-to-evict-per-node and evict-local-storage-pods flags and promote then to policy v1alpha1 fields
ingvagabund
pushed a commit
to ingvagabund/descheduler
that referenced
this pull request
Feb 25, 2026
…er/release-4.21/registry.access.redhat.com-ubi9-ubi-minimal-latest chore(deps): update registry.access.redhat.com/ubi9/ubi-minimal:latest docker digest to 90bd85d - abandoned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--node-selectorpromoted tonodeSelector--evict-local-storage-podspromoted toevictLocalStoragePods--max-pods-to-evict-per-nodepromoted tomaxNoOfPodsToEvictPerNodeConfiguration in the descheduler policy takes preference over the flags
Keeping
descheduling-intervalflag as it is since it's not related to a particular strategy but to the overall controller configuration.